vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Prime comment meta caches in WP_Comment_Query.

Browse Source 
The new 'update_comment_meta_cache' parameter, which defaults to `true`, can
be used to disable this behavior.

`update_comment_cache()` has been updated to support an `$update_meta_cache`
parameter, which also updates to true; this matches the pattern we use for
priming post caches.

See #16894.

git-svn-id: https://develop.svn.wordpress.org/trunk@34268 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2015-09-17 19:29:46 +00:00
parent b08a176488
commit 12329f5ef8
3 changed files with 95 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

77
tests/phpunit/tests/comment/metaCache.php
View File

@@ -4,6 +4,83 @@ class Tests_Comment_Meta_Cache extends WP_UnitTestCase {
protected $i = 0;
protected $queries = 0;
/**
* @ticket 16894
*/
public function test_update_comment_meta_cache_should_default_to_true() {
global $wpdb;
$p = $this->factory->post->create( array( 'post_status' => 'publish' ) );
$comment_ids = $this->factory->comment->create_post_comments( $p, 3 );
foreach ( $comment_ids as $cid ) {
update_comment_meta( $cid, 'foo', 'bar' );
}
$q = new WP_Comment_Query( array(
'post_ID' => $p,
) );
$num_queries = $wpdb->num_queries;
foreach ( $comment_ids as $cid ) {
get_comment_meta( $cid, 'foo', 'bar' );
}
$this->assertSame( $num_queries, $wpdb->num_queries );
}
/**
* @ticket 16894
*/
public function test_update_comment_meta_cache_true() {
global $wpdb;
$p = $this->factory->post->create( array( 'post_status' => 'publish' ) );
$comment_ids = $this->factory->comment->create_post_comments( $p, 3 );
foreach ( $comment_ids as $cid ) {
update_comment_meta( $cid, 'foo', 'bar' );
}
$q = new WP_Comment_Query( array(
'post_ID' => $p,
'update_comment_meta_cache' => true,
) );
$num_queries = $wpdb->num_queries;
foreach ( $comment_ids as $cid ) {
get_comment_meta( $cid, 'foo', 'bar' );
}
$this->assertSame( $num_queries, $wpdb->num_queries );
}
/**
* @ticket 16894
*/
public function test_update_comment_meta_cache_false() {
global $wpdb;
$p = $this->factory->post->create( array( 'post_status' => 'publish' ) );
$comment_ids = $this->factory->comment->create_post_comments( $p, 3 );
foreach ( $comment_ids as $cid ) {
update_comment_meta( $cid, 'foo', 'bar' );
}
$q = new WP_Comment_Query( array(
'post_ID' => $p,
'update_comment_meta_cache' => false,
) );
$num_queries = $wpdb->num_queries;
foreach ( $comment_ids as $cid ) {
get_comment_meta( $cid, 'foo', 'bar' );
}
$this->assertSame( $num_queries + 3, $wpdb->num_queries );
}
public function test_comment_meta_cache() {
$post_id = $this->factory->post->create( array(
'post_status' => 'publish'