From 14d9ca8da64688f799695eb9683e6ac8166cd4ee Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Thu, 21 Apr 2022 11:22:45 +0000 Subject: [PATCH] Code Modernization: Rename parameters that use reserved keywords in `wp-includes/atomlib.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$string` parameter to `$content` in `AtomParser::xml_escape()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. git-svn-id: https://develop.svn.wordpress.org/trunk@53239 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/atomlib.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/atomlib.php b/src/wp-includes/atomlib.php index 97f85baf2d..90f6282243 100644 --- a/src/wp-includes/atomlib.php +++ b/src/wp-includes/atomlib.php @@ -388,10 +388,10 @@ class AtomParser { return false; } - function xml_escape($string) + function xml_escape($content) { return str_replace(array('&','"',"'",'<','>'), array('&','"',''','<','>'), - $string ); + $content ); } }