From 15a26902a68e86727452b3eecef39a799cf4809e Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Fri, 19 Feb 2016 18:43:04 +0000 Subject: [PATCH] Accessibility: Improve color contrast updating any `#999` gray used for text or icons to a darker gray. Fixes #35660. git-svn-id: https://develop.svn.wordpress.org/trunk@36587 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/css/admin-menu.css | 2 +- src/wp-admin/css/common.css | 4 ++-- src/wp-admin/css/dashboard.css | 9 +++++++-- src/wp-admin/css/install.css | 2 +- src/wp-admin/css/list-tables.css | 2 +- src/wp-admin/css/media.css | 2 +- src/wp-admin/css/nav-menus.css | 6 +++--- src/wp-admin/css/press-this.css | 2 +- src/wp-admin/css/themes.css | 7 +++---- src/wp-admin/css/widgets.css | 3 ++- src/wp-admin/includes/misc.php | 2 +- src/wp-includes/css/admin-bar.css | 4 ++-- src/wp-includes/css/media-views.css | 2 +- src/wp-includes/general-template.php | 2 +- 14 files changed, 27 insertions(+), 22 deletions(-) diff --git a/src/wp-admin/css/admin-menu.css b/src/wp-admin/css/admin-menu.css index c6616a4686..337cde00a2 100644 --- a/src/wp-admin/css/admin-menu.css +++ b/src/wp-admin/css/admin-menu.css @@ -38,7 +38,7 @@ /* New Menu icons */ .icon16:before { - color: #999; + color: #82878c; /* same as new icons */ font: normal 20px/1 dashicons; speak: none; padding: 6px 0; diff --git a/src/wp-admin/css/common.css b/src/wp-admin/css/common.css index e0df5865f3..92eb57ef2e 100644 --- a/src/wp-admin/css/common.css +++ b/src/wp-admin/css/common.css @@ -443,7 +443,7 @@ code { .subsubsub a .count, .subsubsub a.current .count { - color: #999; + color: #555d66; /* #f1f1f1 background */ font-weight: normal; } @@ -693,7 +693,7 @@ ul.striped > :nth-child(odd), } .wp-ui-text-icon { - color: #999; + color: #82878c; /* same as new icons */ } /* For emoji replacement images */ diff --git a/src/wp-admin/css/dashboard.css b/src/wp-admin/css/dashboard.css index 67e2ca5cca..0d5f6e03d1 100644 --- a/src/wp-admin/css/dashboard.css +++ b/src/wp-admin/css/dashboard.css @@ -608,7 +608,7 @@ form.initial-form.quickpress-open input#title { } #dashboard_activity .no-activity p { - color: #999; + color: #72777c; font-size: 16px; } @@ -637,6 +637,11 @@ form.initial-form.quickpress-open input#title { padding: 8px 12px 4px; } +#dashboard_activity .subsubsub a .count, +#dashboard_activity .subsubsub a.current .count { + color: #72777c; /* white background on the dashboard but #f1f1f1 on list tables */ +} + #future-posts ul, #published-posts ul { clear: both; @@ -873,7 +878,7 @@ a.rsswidget { } .rss-widget span.rss-date { - color: #999; + color: #72777c; font-size: 13px; margin-left: 3px; } diff --git a/src/wp-admin/css/install.css b/src/wp-admin/css/install.css index e800de5399..c033ea5500 100644 --- a/src/wp-admin/css/install.css +++ b/src/wp-admin/css/install.css @@ -97,7 +97,7 @@ label { background-size: 84px; background-position: center top; background-repeat: no-repeat; - color: #999; + color: #444; /* same as login.css */ height: 84px; font-size: 20px; font-weight: normal; diff --git a/src/wp-admin/css/list-tables.css b/src/wp-admin/css/list-tables.css index b88a864eaa..c0b8d36ed8 100644 --- a/src/wp-admin/css/list-tables.css +++ b/src/wp-admin/css/list-tables.css @@ -1642,7 +1642,7 @@ div.action-links, } .no-plugin-results { - color: #999; + color: #666; /* same as no themes and no media */ font-size: 18px; font-style: normal; margin: 0; diff --git a/src/wp-admin/css/media.css b/src/wp-admin/css/media.css index d0d74092dc..0912854505 100644 --- a/src/wp-admin/css/media.css +++ b/src/wp-admin/css/media.css @@ -609,7 +609,7 @@ border color while dragging a file over the uploader drop area */ } .media-frame.mode-grid .attachments-browser .no-media { - color: #999; + color: #666; /* same as no plugins and no themes */ font-size: 18px; font-style: normal; margin: 0; diff --git a/src/wp-admin/css/nav-menus.css b/src/wp-admin/css/nav-menus.css index ccca9fc3c8..5e8abf76a0 100644 --- a/src/wp-admin/css/nav-menus.css +++ b/src/wp-admin/css/nav-menus.css @@ -69,7 +69,7 @@ ul.add-menu-item-tabs li { } .is-submenu { - color: #999; + color: #555d66; /* #fafafa background */ font-style: italic; font-weight: normal; margin-left: 4px; @@ -134,7 +134,7 @@ ul.add-menu-item-tabs li { } .theme-location-set { - color: #999; + color: #72777c; font-size: 11px; } @@ -484,7 +484,7 @@ ul.add-menu-item-tabs li { } .menu-item-handle .menu-item-title.no-title { - color: #999; + color: #72777c; } /* Sortables */ diff --git a/src/wp-admin/css/press-this.css b/src/wp-admin/css/press-this.css index 2d77da5532..ce1711f524 100644 --- a/src/wp-admin/css/press-this.css +++ b/src/wp-admin/css/press-this.css @@ -1197,7 +1197,7 @@ html { } .adminbar .dashicons { - color: #999; + color: #a0a5aa; /* same as WP admin bar icons */ } .press-this .adminbar button { diff --git a/src/wp-admin/css/themes.css b/src/wp-admin/css/themes.css index 318126bb70..4e15e3ed32 100644 --- a/src/wp-admin/css/themes.css +++ b/src/wp-admin/css/themes.css @@ -303,7 +303,6 @@ } .theme-browser .theme.add-new-theme a { - color: #999; text-decoration: none; display: block; position: relative; @@ -725,7 +724,7 @@ body.folded .theme-overlay .theme-wrap { } .theme-overlay .theme-version { - color: #999; + color: #72777c; font-size: 13px; font-weight: 400; float: none; @@ -1091,7 +1090,7 @@ body.show-upload-theme .upload-theme, } .upload-theme .install-help, .upload-plugin .install-help { - color: #999; + color: #555d66; /* #f1f1f1 background */ font-size: 18px; font-style: normal; margin: 0; @@ -1149,7 +1148,7 @@ body.show-upload-theme p.no-themes { .theme-details .num-ratings, .theme-details .no-rating { font-size: 11px; - color: #999; + color: #72777c; } .theme-details .no-rating { diff --git a/src/wp-admin/css/widgets.css b/src/wp-admin/css/widgets.css index 72c3bdd299..c2d6754fdd 100644 --- a/src/wp-admin/css/widgets.css +++ b/src/wp-admin/css/widgets.css @@ -461,6 +461,7 @@ div#widgets-right .widget-top:hover, transition: background 0.2s ease-in-out; } + /* @todo looks like these hover/focus states are overridden by .widgets-chooser-selected */ .widgets-chooser li:hover, .widgets-chooser li:focus { background: rgba(255,255,255,0.7); @@ -471,7 +472,7 @@ div#widgets-right .widget-top:hover, display: block; -webkit-font-smoothing: antialiased; font: normal 26px/1 dashicons; - color: #999; + color: #555d66; position: absolute; top: 7px; left: 5px; diff --git a/src/wp-admin/includes/misc.php b/src/wp-admin/includes/misc.php index 53172b1ad6..64cc521544 100644 --- a/src/wp-admin/includes/misc.php +++ b/src/wp-admin/includes/misc.php @@ -710,7 +710,7 @@ function wp_color_scheme_settings() { $icon_colors = $_wp_admin_css_colors['fresh']->icon_colors; } else { // Fall back to the default set of icon colors if the default scheme is missing. - $icon_colors = array( 'base' => '#999', 'focus' => '#00a0d2', 'current' => '#fff' ); + $icon_colors = array( 'base' => '#82878c', 'focus' => '#00a0d2', 'current' => '#fff' ); } echo '\n"; diff --git a/src/wp-includes/css/admin-bar.css b/src/wp-includes/css/admin-bar.css index ab88981c22..bab7104ec9 100644 --- a/src/wp-includes/css/admin-bar.css +++ b/src/wp-includes/css/admin-bar.css @@ -453,7 +453,7 @@ html:lang(he-il) .rtl #wpadminbar * { } #wpadminbar #wp-admin-bar-user-info .username { - color: #999; + color: #a0a5aa; font-size: 11px; } @@ -906,7 +906,7 @@ html:lang(he-il) .rtl #wpadminbar * { overflow: hidden; width: 52px; padding: 0; - color: #999; + color: #a0a5aa; /* @todo not needed? this text is hidden */ position: relative; } diff --git a/src/wp-includes/css/media-views.css b/src/wp-includes/css/media-views.css index d131c29d4e..9e03aa2c44 100644 --- a/src/wp-includes/css/media-views.css +++ b/src/wp-includes/css/media-views.css @@ -2006,7 +2006,7 @@ } .image-details .custom-size span small { - color: #999; + color: #555d66; /* #f3f3f3 background */ font-size: inherit; } diff --git a/src/wp-includes/general-template.php b/src/wp-includes/general-template.php index 3946d13158..1669ae355d 100644 --- a/src/wp-includes/general-template.php +++ b/src/wp-includes/general-template.php @@ -3144,7 +3144,7 @@ function register_admin_color_schemes() { wp_admin_css_color( 'fresh', _x( 'Default', 'admin color scheme' ), false, array( '#222', '#333', '#0073aa', '#00a0d2' ), - array( 'base' => '#999', 'focus' => '#00a0d2', 'current' => '#fff' ) + array( 'base' => '#82878c', 'focus' => '#00a0d2', 'current' => '#fff' ) ); // Other color schemes are not available when running out of src