vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 22:30:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

Browse Source 
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

git-svn-id: https://develop.svn.wordpress.org/trunk@48937 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2020-09-02 00:35:36 +00:00
parent ba7c6a2d5f
commit 164b22cf6a
426 changed files with 7959 additions and 7949 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
tests/phpunit/tests/cache.php
View File

@@ -35,7 +35,7 @@ class Tests_Cache extends WP_UnitTestCase {
$val = 'val';
$this->cache->add( $key, $val );
$this->assertEquals( $val, $this->cache->get( $key ) );
$this->assertSame( $val, $this->cache->get( $key ) );
}
function test_add_get_0() {
@@ -44,7 +44,7 @@ class Tests_Cache extends WP_UnitTestCase {
// You can store zero in the cache.
$this->cache->add( $key, $val );
$this->assertEquals( $val, $this->cache->get( $key ) );
$this->assertSame( $val, $this->cache->get( $key ) );
}
function test_add_get_null() {
@@ -63,10 +63,10 @@ class Tests_Cache extends WP_UnitTestCase {
// Add $key to the cache.
$this->assertTrue( $this->cache->add( $key, $val1 ) );
$this->assertEquals( $val1, $this->cache->get( $key ) );
$this->assertSame( $val1, $this->cache->get( $key ) );
// $key is in the cache, so reject new calls to add().
$this->assertFalse( $this->cache->add( $key, $val2 ) );
$this->assertEquals( $val1, $this->cache->get( $key ) );
$this->assertSame( $val1, $this->cache->get( $key ) );
}
function test_replace() {
@@ -78,9 +78,9 @@ class Tests_Cache extends WP_UnitTestCase {
$this->assertFalse( $this->cache->replace( $key, $val ) );
$this->assertFalse( $this->cache->get( $key ) );
$this->assertTrue( $this->cache->add( $key, $val ) );
$this->assertEquals( $val, $this->cache->get( $key ) );
$this->assertSame( $val, $this->cache->get( $key ) );
$this->assertTrue( $this->cache->replace( $key, $val2 ) );
$this->assertEquals( $val2, $this->cache->get( $key ) );
$this->assertSame( $val2, $this->cache->get( $key ) );
}
function test_set() {
@@ -90,10 +90,10 @@ class Tests_Cache extends WP_UnitTestCase {
// memcached accepts set() if the key does not exist.
$this->assertTrue( $this->cache->set( $key, $val1 ) );
$this->assertEquals( $val1, $this->cache->get( $key ) );
$this->assertSame( $val1, $this->cache->get( $key ) );
// Second set() with same key should be allowed.
$this->assertTrue( $this->cache->set( $key, $val2 ) );
$this->assertEquals( $val2, $this->cache->get( $key ) );
$this->assertSame( $val2, $this->cache->get( $key ) );
}
function test_flush() {
@@ -108,7 +108,7 @@ class Tests_Cache extends WP_UnitTestCase {
$this->cache->add( $key, $val );
// Item is visible to both cache objects.
$this->assertEquals( $val, $this->cache->get( $key ) );
$this->assertSame( $val, $this->cache->get( $key ) );
$this->cache->flush();
// If there is no value get returns false.
$this->assertFalse( $this->cache->get( $key ) );
@@ -122,9 +122,9 @@ class Tests_Cache extends WP_UnitTestCase {
$this->cache->set( $key, $object_a );
$object_a->foo = 'bravo';
$object_b = $this->cache->get( $key );
$this->assertEquals( 'alpha', $object_b->foo );
$this->assertSame( 'alpha', $object_b->foo );
$object_b->foo = 'charlie';
$this->assertEquals( 'bravo', $object_a->foo );
$this->assertSame( 'bravo', $object_a->foo );
$key = __FUNCTION__ . '_2';
$object_a = new stdClass;
@@ -132,9 +132,9 @@ class Tests_Cache extends WP_UnitTestCase {
$this->cache->add( $key, $object_a );
$object_a->foo = 'bravo';
$object_b = $this->cache->get( $key );
$this->assertEquals( 'alpha', $object_b->foo );
$this->assertSame( 'alpha', $object_b->foo );
$object_b->foo = 'charlie';
$this->assertEquals( 'bravo', $object_a->foo );
$this->assertSame( 'bravo', $object_a->foo );
}
function test_incr() {
@@ -144,10 +144,10 @@ class Tests_Cache extends WP_UnitTestCase {
$this->cache->set( $key, 0 );
$this->cache->incr( $key );
$this->assertEquals( 1, $this->cache->get( $key ) );
$this->assertSame( 1, $this->cache->get( $key ) );
$this->cache->incr( $key, 2 );
$this->assertEquals( 3, $this->cache->get( $key ) );
$this->assertSame( 3, $this->cache->get( $key ) );
}
function test_wp_cache_incr() {
@@ -157,10 +157,10 @@ class Tests_Cache extends WP_UnitTestCase {
wp_cache_set( $key, 0 );
wp_cache_incr( $key );
$this->assertEquals( 1, wp_cache_get( $key ) );
$this->assertSame( 1, wp_cache_get( $key ) );
wp_cache_incr( $key, 2 );
$this->assertEquals( 3, wp_cache_get( $key ) );
$this->assertSame( 3, wp_cache_get( $key ) );
}
function test_decr() {
@@ -170,14 +170,14 @@ class Tests_Cache extends WP_UnitTestCase {
$this->cache->set( $key, 0 );
$this->cache->decr( $key );
$this->assertEquals( 0, $this->cache->get( $key ) );
$this->assertSame( 0, $this->cache->get( $key ) );
$this->cache->set( $key, 3 );
$this->cache->decr( $key );
$this->assertEquals( 2, $this->cache->get( $key ) );
$this->assertSame( 2, $this->cache->get( $key ) );
$this->cache->decr( $key, 2 );
$this->assertEquals( 0, $this->cache->get( $key ) );
$this->assertSame( 0, $this->cache->get( $key ) );
}
/**
@@ -190,14 +190,14 @@ class Tests_Cache extends WP_UnitTestCase {
wp_cache_set( $key, 0 );
wp_cache_decr( $key );
$this->assertEquals( 0, wp_cache_get( $key ) );
$this->assertSame( 0, wp_cache_get( $key ) );
wp_cache_set( $key, 3 );
wp_cache_decr( $key );
$this->assertEquals( 2, wp_cache_get( $key ) );
$this->assertSame( 2, wp_cache_get( $key ) );
wp_cache_decr( $key, 2 );
$this->assertEquals( 0, wp_cache_get( $key ) );
$this->assertSame( 0, wp_cache_get( $key ) );
}
function test_delete() {
@@ -206,7 +206,7 @@ class Tests_Cache extends WP_UnitTestCase {
// Verify set.
$this->assertTrue( $this->cache->set( $key, $val ) );
$this->assertEquals( $val, $this->cache->get( $key ) );
$this->assertSame( $val, $this->cache->get( $key ) );
// Verify successful delete.
$this->assertTrue( $this->cache->delete( $key ) );
@@ -221,7 +221,7 @@ class Tests_Cache extends WP_UnitTestCase {
// Verify set.
$this->assertTrue( wp_cache_set( $key, $val ) );
$this->assertEquals( $val, wp_cache_get( $key ) );
$this->assertSame( $val, wp_cache_get( $key ) );
// Verify successful delete.
$this->assertTrue( wp_cache_delete( $key ) );
@@ -246,38 +246,38 @@ class Tests_Cache extends WP_UnitTestCase {
if ( ! is_multisite() ) {
// Single site ingnores switch_to_blog().
$this->assertTrue( $this->cache->set( $key, $val ) );
$this->assertEquals( $val, $this->cache->get( $key ) );
$this->assertSame( $val, $this->cache->get( $key ) );
$this->cache->switch_to_blog( 999 );
$this->assertEquals( $val, $this->cache->get( $key ) );
$this->assertSame( $val, $this->cache->get( $key ) );
$this->assertTrue( $this->cache->set( $key, $val2 ) );
$this->assertEquals( $val2, $this->cache->get( $key ) );
$this->assertSame( $val2, $this->cache->get( $key ) );
$this->cache->switch_to_blog( get_current_blog_id() );
$this->assertEquals( $val2, $this->cache->get( $key ) );
$this->assertSame( $val2, $this->cache->get( $key ) );
} else {
// Multisite should have separate per-blog caches.
$this->assertTrue( $this->cache->set( $key, $val ) );
$this->assertEquals( $val, $this->cache->get( $key ) );
$this->assertSame( $val, $this->cache->get( $key ) );
$this->cache->switch_to_blog( 999 );
$this->assertFalse( $this->cache->get( $key ) );
$this->assertTrue( $this->cache->set( $key, $val2 ) );
$this->assertEquals( $val2, $this->cache->get( $key ) );
$this->assertSame( $val2, $this->cache->get( $key ) );
$this->cache->switch_to_blog( get_current_blog_id() );
$this->assertEquals( $val, $this->cache->get( $key ) );
$this->assertSame( $val, $this->cache->get( $key ) );
$this->cache->switch_to_blog( 999 );
$this->assertEquals( $val2, $this->cache->get( $key ) );
$this->assertSame( $val2, $this->cache->get( $key ) );
$this->cache->switch_to_blog( get_current_blog_id() );
$this->assertEquals( $val, $this->cache->get( $key ) );
$this->assertSame( $val, $this->cache->get( $key ) );
}
// Global group.
$this->assertTrue( $this->cache->set( $key, $val, 'global-cache-test' ) );
$this->assertEquals( $val, $this->cache->get( $key, 'global-cache-test' ) );
$this->assertSame( $val, $this->cache->get( $key, 'global-cache-test' ) );
$this->cache->switch_to_blog( 999 );
$this->assertEquals( $val, $this->cache->get( $key, 'global-cache-test' ) );
$this->assertSame( $val, $this->cache->get( $key, 'global-cache-test' ) );
$this->assertTrue( $this->cache->set( $key, $val2, 'global-cache-test' ) );
$this->assertEquals( $val2, $this->cache->get( $key, 'global-cache-test' ) );
$this->assertSame( $val2, $this->cache->get( $key, 'global-cache-test' ) );
$this->cache->switch_to_blog( get_current_blog_id() );
$this->assertEquals( $val2, $this->cache->get( $key, 'global-cache-test' ) );
$this->assertSame( $val2, $this->cache->get( $key, 'global-cache-test' ) );
}
function test_wp_cache_init() {
@@ -303,11 +303,11 @@ class Tests_Cache extends WP_UnitTestCase {
// Save the first value to cache and verify.
wp_cache_set( $key, $val1 );
$this->assertEquals( $val1, wp_cache_get( $key ) );
$this->assertSame( $val1, wp_cache_get( $key ) );
// Replace the value and verify.
wp_cache_replace( $key, $val2 );
$this->assertEquals( $val2, wp_cache_get( $key ) );
$this->assertSame( $val2, wp_cache_get( $key ) );
// Non-existant key should fail.
$this->assertFalse( wp_cache_replace( $fake_key, $val1 ) );