vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

Browse Source 
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

git-svn-id: https://develop.svn.wordpress.org/trunk@48937 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2020-09-02 00:35:36 +00:00
parent ba7c6a2d5f
commit 164b22cf6a
426 changed files with 7959 additions and 7949 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/phpunit/tests/formatting/MapDeep.php
View File

@@ -7,11 +7,11 @@
class Tests_Formatting_MapDeep extends WP_UnitTestCase {
public function test_map_deep_with_any_function_over_empty_array_should_return_empty_array() {
$this->assertEquals( array(), map_deep( array(), array( $this, 'append_baba' ) ) );
$this->assertSame( array(), map_deep( array(), array( $this, 'append_baba' ) ) );
}
public function test_map_deep_should_map_each_element_of_array_one_level_deep() {
$this->assertEquals(
$this->assertSame(
array(
'ababa',
'xbaba',
@@ -27,7 +27,7 @@ class Tests_Formatting_MapDeep extends WP_UnitTestCase {
}
public function test_map_deep_should_map_each_element_of_array_two_levels_deep() {
$this->assertEquals(
$this->assertSame(
array(
'ababa',
array(
@@ -67,11 +67,11 @@ class Tests_Formatting_MapDeep extends WP_UnitTestCase {
}
public function test_map_deep_should_apply_the_function_to_a_string() {
$this->assertEquals( 'xbaba', map_deep( 'x', array( $this, 'append_baba' ) ) );
$this->assertSame( 'xbaba', map_deep( 'x', array( $this, 'append_baba' ) ) );
}
public function test_map_deep_should_apply_the_function_to_an_integer() {
$this->assertEquals( '5baba', map_deep( 5, array( $this, 'append_baba' ) ) );
$this->assertSame( '5baba', map_deep( 5, array( $this, 'append_baba' ) ) );
}
public function test_map_deep_should_map_each_property_of_an_object() {
@@ -157,7 +157,7 @@ class Tests_Formatting_MapDeep extends WP_UnitTestCase {
'var0' => &$array_a['var0'],
'var1' => 'x',
);
$this->assertEquals(
$this->assertSame(
array(
'var0' => 'ababa',
'var1' => 'xbaba',