vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-12 21:00:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

Browse Source 
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

git-svn-id: https://develop.svn.wordpress.org/trunk@48937 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2020-09-02 00:35:36 +00:00
parent ba7c6a2d5f
commit 164b22cf6a
426 changed files with 7959 additions and 7949 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/http/functions.php
+12 -12
View File
@@ -25,9 +25,9 @@ class Tests_HTTP_Functions extends WP_UnitTestCase {
$this->assertInternalType( 'array', $response );
$this->assertEquals( 'image/jpeg', $headers['content-type'] );
$this->assertEquals( '40148', $headers['content-length'] );
$this->assertEquals( '200', wp_remote_retrieve_response_code( $response ) );
$this->assertSame( 'image/jpeg', $headers['content-type'] );
$this->assertSame( '40148', $headers['content-length'] );
$this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
}
function test_head_redirect() {
@@ -36,7 +36,7 @@ class Tests_HTTP_Functions extends WP_UnitTestCase {
$response = wp_remote_head( $url );
$this->skipTestOnTimeout( $response );
$this->assertEquals( '301', wp_remote_retrieve_response_code( $response ) );
$this->assertSame( 301, wp_remote_retrieve_response_code( $response ) );
}
function test_head_404() {
@@ -44,7 +44,7 @@ class Tests_HTTP_Functions extends WP_UnitTestCase {
$response = wp_remote_head( $url );
$this->skipTestOnTimeout( $response );
$this->assertEquals( '404', wp_remote_retrieve_response_code( $response ) );
$this->assertSame( 404, wp_remote_retrieve_response_code( $response ) );
}
function test_get_request() {
@@ -59,9 +59,9 @@ class Tests_HTTP_Functions extends WP_UnitTestCase {
$this->assertInternalType( 'array', $response );
// Should return the same headers as a HEAD request.
$this->assertEquals( 'image/jpeg', $headers['content-type'] );
$this->assertEquals( '40148', $headers['content-length'] );
$this->assertEquals( '200', wp_remote_retrieve_response_code( $response ) );
$this->assertSame( 'image/jpeg', $headers['content-type'] );
$this->assertSame( '40148', $headers['content-length'] );
$this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
}
function test_get_redirect() {
@@ -75,9 +75,9 @@ class Tests_HTTP_Functions extends WP_UnitTestCase {
$headers = wp_remote_retrieve_headers( $response );
// Should return the same headers as a HEAD request.
$this->assertEquals( 'image/jpeg', $headers['content-type'] );
$this->assertEquals( '40148', $headers['content-length'] );
$this->assertEquals( '200', wp_remote_retrieve_response_code( $response ) );
$this->assertSame( 'image/jpeg', $headers['content-type'] );
$this->assertSame( '40148', $headers['content-length'] );
$this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
}
function test_get_redirect_limit_exceeded() {
@@ -196,7 +196,7 @@ class Tests_HTTP_Functions extends WP_UnitTestCase {
// Check the host_only flag in the resulting WP_Http_Cookie.
$cookie = wp_remote_retrieve_cookie( $response, 'test' );
$this->assertEquals( $cookie->domain, 'wordpress.org' );
$this->assertSame( $cookie->domain, 'wordpress.org' );
$this->assertFalse( $cookie->host_only, 'host-only flag not set' );
// Regurgitate (Requests_Cookie -> WP_Http_Cookie -> Requests_Cookie).