vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-11 20:30:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

Browse Source 
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

git-svn-id: https://develop.svn.wordpress.org/trunk@48937 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2020-09-02 00:35:36 +00:00
parent ba7c6a2d5f
commit 164b22cf6a
426 changed files with 7959 additions and 7949 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/meta.php
+24 -24
View File
@@ -19,11 +19,11 @@ class Tests_Meta extends WP_UnitTestCase {
function test_sanitize_meta() {
$meta = sanitize_meta( 'some_meta', 'unsanitized', 'post' );
$this->assertEquals( 'unsanitized', $meta );
$this->assertSame( 'unsanitized', $meta );
register_meta( 'post', 'some_meta', array( $this, '_meta_sanitize_cb' ) );
$meta = sanitize_meta( 'some_meta', 'unsanitized', 'post' );
$this->assertEquals( 'sanitized', $meta );
$this->assertSame( 'sanitized', $meta );
}
function test_delete_metadata_by_mid() {
@@ -48,23 +48,23 @@ class Tests_Meta extends WP_UnitTestCase {
// Update the meta value.
$this->assertTrue( update_metadata_by_mid( 'user', $this->meta_id, 'meta_new_value' ) );
$meta = get_metadata_by_mid( 'user', $this->meta_id );
$this->assertEquals( 'meta_new_value', $meta->meta_value );
$this->assertSame( 'meta_new_value', $meta->meta_value );
// Update the meta value.
$this->assertTrue( update_metadata_by_mid( 'user', $this->meta_id, 'meta_new_value', 'meta_new_key' ) );
$meta = get_metadata_by_mid( 'user', $this->meta_id );
$this->assertEquals( 'meta_new_key', $meta->meta_key );
$this->assertSame( 'meta_new_key', $meta->meta_key );
// Update the key and value.
$this->assertTrue( update_metadata_by_mid( 'user', $this->meta_id, 'meta_value', 'meta_key' ) );
$meta = get_metadata_by_mid( 'user', $this->meta_id );
$this->assertEquals( 'meta_key', $meta->meta_key );
$this->assertEquals( 'meta_value', $meta->meta_value );
$this->assertSame( 'meta_key', $meta->meta_key );
$this->assertSame( 'meta_value', $meta->meta_value );
// Update the value that has to be serialized.
$this->assertTrue( update_metadata_by_mid( 'user', $this->meta_id, array( 'first', 'second' ) ) );
$meta = get_metadata_by_mid( 'user', $this->meta_id );
$this->assertEquals( array( 'first', 'second' ), $meta->meta_value );
$this->assertSame( array( 'first', 'second' ), $meta->meta_value );
// Let's try some invalid meta data.
$this->assertFalse( update_metadata_by_mid( 'user', 0, 'meta_value' ) );
@@ -137,13 +137,13 @@ class Tests_Meta extends WP_UnitTestCase {
)
);
$this->assertEquals( 1, count( $u ) );
$this->assertSame( 1, count( $u ) );
// User found is not locally defined author (it's the admin).
$this->assertNotEquals( $this->author->user_login, $u[0]->user_login );
// Test EXISTS and NOT EXISTS together, no users should be found.
$this->assertEquals(
$this->assertSame(
0,
count(
get_users(
@@ -163,7 +163,7 @@ class Tests_Meta extends WP_UnitTestCase {
)
);
$this->assertEquals(
$this->assertSame(
2,
count(
get_users(
@@ -181,7 +181,7 @@ class Tests_Meta extends WP_UnitTestCase {
delete_metadata( 'user', $this->author->ID, 'meta_key' );
$this->assertEquals(
$this->assertSame(
2,
count(
get_users(
@@ -208,24 +208,24 @@ class Tests_Meta extends WP_UnitTestCase {
$this->assertFalse( delete_metadata( 'user', $this->author->ID, $key ) );
$this->assertSame( '', get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertInternalType( 'int', add_metadata( 'user', $this->author->ID, $key, $value ) );
$this->assertEquals( $expected, get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertSame( $expected, get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertTrue( delete_metadata( 'user', $this->author->ID, $key ) );
$this->assertSame( '', get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertInternalType( 'int', update_metadata( 'user', $this->author->ID, $key, $value ) );
$this->assertEquals( $expected, get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertSame( $expected, get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertTrue( update_metadata( 'user', $this->author->ID, $key, 'blah' ) );
$this->assertEquals( 'blah', get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertSame( 'blah', get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertTrue( delete_metadata( 'user', $this->author->ID, $key ) );
$this->assertSame( '', get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertFalse( metadata_exists( 'user', $this->author->ID, $key ) );
// Test overslashing.
$this->assertInternalType( 'int', add_metadata( 'user', $this->author->ID, $key, $value2 ) );
$this->assertEquals( $expected2, get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertSame( $expected2, get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertTrue( delete_metadata( 'user', $this->author->ID, $key ) );
$this->assertSame( '', get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertInternalType( 'int', update_metadata( 'user', $this->author->ID, $key, $value2 ) );
$this->assertEquals( $expected2, get_metadata( 'user', $this->author->ID, $key, true ) );
$this->assertSame( $expected2, get_metadata( 'user', $this->author->ID, $key, true ) );
}
/**
@@ -252,8 +252,8 @@ class Tests_Meta extends WP_UnitTestCase {
)
);
$this->assertEquals( array( $post_id2, $post_id1 ), $posts->posts );
$this->assertEquals( 2, substr_count( $posts->request, 'CAST(' ) );
$this->assertSame( array( $post_id2, $post_id1 ), $posts->posts );
$this->assertSame( 2, substr_count( $posts->request, 'CAST(' ) );
// Make sure the newer meta_query syntax behaves in a consistent way.
$posts = new WP_Query(
@@ -273,8 +273,8 @@ class Tests_Meta extends WP_UnitTestCase {
)
);
$this->assertEquals( array( $post_id2, $post_id1 ), $posts->posts );
$this->assertEquals( 2, substr_count( $posts->request, 'CAST(' ) );
$this->assertSame( array( $post_id2, $post_id1 ), $posts->posts );
$this->assertSame( 2, substr_count( $posts->request, 'CAST(' ) );
// The legacy `meta_key` value should take precedence.
$posts = new WP_Query(
@@ -297,8 +297,8 @@ class Tests_Meta extends WP_UnitTestCase {
)
);
$this->assertEquals( array( $post_id2, $post_id1 ), $posts->posts );
$this->assertEquals( 2, substr_count( $posts->request, 'CAST(' ) );
$this->assertSame( array( $post_id2, $post_id1 ), $posts->posts );
$this->assertSame( 2, substr_count( $posts->request, 'CAST(' ) );
}
function test_meta_cache_order_asc() {
@@ -310,7 +310,7 @@ class Tests_Meta extends WP_UnitTestCase {
foreach ( range( 1, 10 ) as $i ) {
$meta = get_post_meta( $post_id, 'color' );
$this->assertEquals( $meta, $colors );
$this->assertSame( $meta, $colors );
if ( 0 === $i % 2 ) {
wp_cache_delete( $post_id, 'post_meta' );
@@ -399,7 +399,7 @@ class Tests_Meta extends WP_UnitTestCase {
add_metadata( 'user', $this->author->ID, 'foo', $data );
$found = get_metadata( 'user', $this->author->ID );
$this->assertEquals( array( $value ), $found['foo'] );
$this->assertSame( array( $value ), $found['foo'] );
}
/**