vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-10-03 06:07:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

Browse Source 
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

git-svn-id: https://develop.svn.wordpress.org/trunk@48937 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2020-09-02 00:35:36 +00:00
parent ba7c6a2d5f
commit 164b22cf6a
426 changed files with 7959 additions and 7949 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/rest-api/rest-controller.php
+14 -14
View File
@@ -106,35 +106,35 @@ class WP_Test_REST_Controller extends WP_Test_REST_TestCase {
);
// Check sanitize testing.
$this->assertEquals(
$this->assertSame(
false,
rest_sanitize_request_arg( 'false', $this->request, 'someboolean' )
);
$this->assertEquals(
$this->assertSame(
false,
rest_sanitize_request_arg( '0', $this->request, 'someboolean' )
);
$this->assertEquals(
$this->assertSame(
false,
rest_sanitize_request_arg( 0, $this->request, 'someboolean' )
);
$this->assertEquals(
$this->assertSame(
false,
rest_sanitize_request_arg( 'FALSE', $this->request, 'someboolean' )
);
$this->assertEquals(
$this->assertSame(
true,
rest_sanitize_request_arg( 'true', $this->request, 'someboolean' )
);
$this->assertEquals(
$this->assertSame(
true,
rest_sanitize_request_arg( '1', $this->request, 'someboolean' )
);
$this->assertEquals(
$this->assertSame(
true,
rest_sanitize_request_arg( 1, $this->request, 'someboolean' )
);
$this->assertEquals(
$this->assertSame(
true,
rest_sanitize_request_arg( 'TRUE', $this->request, 'someboolean' )
);
@@ -225,7 +225,7 @@ class WP_Test_REST_Controller extends WP_Test_REST_TestCase {
public function test_get_endpoint_args_for_item_schema_description() {
$controller = new WP_REST_Test_Controller();
$args = $controller->get_endpoint_args_for_item_schema();
$this->assertEquals( 'A pretty string.', $args['somestring']['description'] );
$this->assertSame( 'A pretty string.', $args['somestring']['description'] );
$this->assertFalse( isset( $args['someinteger']['description'] ) );
}
@@ -235,7 +235,7 @@ class WP_Test_REST_Controller extends WP_Test_REST_TestCase {
$args = $controller->get_endpoint_args_for_item_schema();
$this->assertFalse( $args['someargoptions']['required'] );
$this->assertEquals( '__return_true', $args['someargoptions']['sanitize_callback'] );
$this->assertSame( '__return_true', $args['someargoptions']['sanitize_callback'] );
}
public function test_get_endpoint_args_for_item_schema_default_value() {
@@ -244,7 +244,7 @@ class WP_Test_REST_Controller extends WP_Test_REST_TestCase {
$args = $controller->get_endpoint_args_for_item_schema();
$this->assertEquals( 'a', $args['somedefault']['default'] );
$this->assertSame( 'a', $args['somedefault']['default'] );
}
/**
@@ -285,7 +285,7 @@ class WP_Test_REST_Controller extends WP_Test_REST_TestCase {
$controller = new WP_REST_Test_Controller();
$request = new WP_REST_Request( 'GET', '/wp/v2/testroute' );
$fields = $controller->get_fields_for_response( $request );
$this->assertEquals(
$this->assertSame(
array(
'somestring',
'someinteger',
@@ -305,7 +305,7 @@ class WP_Test_REST_Controller extends WP_Test_REST_TestCase {
);
$request->set_param( '_fields', $param );
$fields = $controller->get_fields_for_response( $request );
$this->assertEquals( $expected, $fields );
$this->assertSame( $expected, $fields );
}
public function data_get_fields_for_response() {
@@ -536,7 +536,7 @@ class WP_Test_REST_Controller extends WP_Test_REST_TestCase {
$response = $controller->prepare_item_for_response( array(), $request );
$response = rest_filter_response_fields( $response, rest_get_server(), $request );
$this->assertEquals( $expected, $response->get_data() );
$this->assertSame( $expected, $response->get_data() );
}
public function register_nested_rest_field_get_callback() {