vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Expand the test for conditional tags returning early if $wp_query is not set.

Browse Source 
When called too early, conditional query tags should throw a `_doing_it_wrong()` notice and return `false`. This commit verifies that behavior not only for `is_main_query()`, but for all the other conditional tags too.

Follow-up to [16947], [17068], [17083], [18699], [37985], [53395].

See #55104.

git-svn-id: https://develop.svn.wordpress.org/trunk@53396 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2022-05-15 15:55:11 +00:00
parent 3da312a954
commit 183dc1a347
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/phpunit/tests/query/conditionals.php
View File

@ -1618,12 +1618,28 @@ class Tests_Query_Conditionals extends WP_UnitTestCase {
/**
* @ticket 55104
* @expectedIncorrectUsage is_main_query
*/
public function test_is_main_query_returns_false_if_wp_query_is_not_set() {
public function test_conditional_tags_trigger_doing_it_wrong_and_return_false_if_wp_query_is_not_set() {
unset( $GLOBALS['wp_query'] );
$this->assertFalse( is_main_query() );
$functions = get_class_methods( 'WP_Query' );
foreach ( $functions as $function_name ) {
// Only test `is_*()` conditional tags.
if ( ! str_starts_with( $function_name, 'is_' ) ) {
continue;
}
if ( 'is_comments_popup' === $function_name ) {
// `is_comments_popup()` is deprecated as of WP 4.5.
$this->setExpectedDeprecated( $function_name );
} else {
// All the other functions should throw a `_doing_it_wrong()` notice.
$this->setExpectedIncorrectUsage( $function_name );
}
$this->assertFalse( call_user_func( $function_name ) );
}
}
}