From 19bc573d35c77aa619ce629d5eeb2519bca69899 Mon Sep 17 00:00:00 2001 From: Andrew Nacin Date: Mon, 29 Jul 2013 17:53:24 +0000 Subject: [PATCH] Fix pass by reference issue. see #24873. git-svn-id: https://develop.svn.wordpress.org/trunk@24866 602fd350-edb4-49c9-b593-d223f7449a82 --- wp-admin/includes/revision.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/wp-admin/includes/revision.php b/wp-admin/includes/revision.php index 89af3c74f9..597ec1f02c 100644 --- a/wp-admin/includes/revision.php +++ b/wp-admin/includes/revision.php @@ -180,10 +180,12 @@ function wp_prepare_revisions_for_js( $post, $selected_revision_id, $from = null $compare_two_mode = is_numeric( $from ); if ( ! $compare_two_mode ) { $found = array_search( $selected_revision_id, array_keys( $revisions ) ); - if ( $found ) - $from = array_shift( array_keys( array_slice( $revisions, $found - 1, 1, true ) ) ); - else + if ( $found ) { + $from = array_keys( array_slice( $revisions, $found - 1, 1, true ) ); + $from = reset( $from ); + } else { $from = 0; + } } $from = absint( $from );