vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-12 12:50:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Widgets: Revert [51705].

Browse Source 
While the new name is much better, it doesn't fully tell what will happen when invoked nor does it fully solve the root problems. 

Why? The function is doing too much. And naming is hard.

Props azaozz, desrosj, andraganescu, zieladam, hellofromTonya.
See #53811.

git-svn-id: https://develop.svn.wordpress.org/trunk@51791 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Tonya Mork
2021-09-09 21:39:39 +00:00
parent 50d7248e1e
commit 1d0e4441c1
8 changed files with 36 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wp-includes/widgets.php
+3 -20
View File
@@ -1251,30 +1251,13 @@ function _wp_sidebars_changed() {
$sidebars_widgets = wp_get_sidebars_widgets();
}
sync_registered_widgets( true );
retrieve_widgets( true );
}
/**
* Do not use, deprecated.
*
* Use sync_registered_widgets() instead.
* Look for "lost" widgets, this has to run at least on each theme change.
*
* @since 2.8.0
* @deprecated 5.8.1 Use sync_registered_widgets()
* @see sync_registered_widgets()
*
* @param string|bool $theme_changed
* @return array
*/
function retrieve_widgets( $theme_changed = false ) {
return sync_registered_widgets( $theme_changed );
}
/**
* Looks for "lost" widgets and Updates widgets-to-sidebars allocation.
* This has to run at least on each theme change.
*
* @since 5.8.1
*
* @global array $wp_registered_sidebars Registered sidebars.
* @global array $sidebars_widgets
@@ -1284,7 +1267,7 @@ function retrieve_widgets( $theme_changed = false ) {
* of 'customize' defers updates for the Customizer.
* @return array Updated sidebars widgets.
*/
function sync_registered_widgets( $theme_changed = false ) {
function retrieve_widgets( $theme_changed = false ) {
global $wp_registered_sidebars, $sidebars_widgets, $wp_registered_widgets;
$registered_sidebars_keys = array_keys( $wp_registered_sidebars );