From 1d19617606382243ac0984698962078773122f05 Mon Sep 17 00:00:00 2001 From: "Dominik Schilling (ocean90)" Date: Wed, 17 Feb 2016 19:41:14 +0000 Subject: [PATCH] Updates: Prevent further actions if an update button is disabled. Props adamsilverstein, afercia. Fixes #35257. git-svn-id: https://develop.svn.wordpress.org/trunk@36558 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/class-wp-plugin-install-list-table.php | 2 +- src/wp-admin/js/updates.js | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/wp-admin/includes/class-wp-plugin-install-list-table.php b/src/wp-admin/includes/class-wp-plugin-install-list-table.php index d3f1b87744..8746230484 100644 --- a/src/wp-admin/includes/class-wp-plugin-install-list-table.php +++ b/src/wp-admin/includes/class-wp-plugin-install-list-table.php @@ -461,7 +461,7 @@ class WP_Plugin_Install_List_Table extends WP_List_Table { case 'update_available': if ( $status['url'] ) { /* translators: 1: Plugin name and version */ - $action_links[] = '' . __( 'Update Now' ) . ''; + $action_links[] = '' . __( 'Update Now' ) . ''; } break; diff --git a/src/wp-admin/js/updates.js b/src/wp-admin/js/updates.js index deb92f155a..35ae6c7d9b 100644 --- a/src/wp-admin/js/updates.js +++ b/src/wp-admin/js/updates.js @@ -524,6 +524,11 @@ window.wp = window.wp || {}; e.preventDefault(); var $button = $( e.target ); + // Do nothing while updating and when the button is disabled. + if ( $button.hasClass( 'updating-message' ) || $button.hasClass( 'button-disabled' ) ) { + return; + } + if ( wp.updates.shouldRequestFilesystemCredentials && ! wp.updates.updateLock ) { wp.updates.requestFilesystemCredentials( e ); }