From 21c0ed05c4ba03786899401a0f73f5b7840e3903 Mon Sep 17 00:00:00 2001
From: Sergey Biryukov <sergeybiryukov@git.wordpress.org>
Date: Tue, 4 Aug 2020 15:55:25 +0000
Subject: [PATCH] Comments: Use the existing static variable instead of calling
 `::has_items()` again in `WP_Comments_List_Table::extra_tablenav()`.

Additionally, removed unnecessary `esc_html()` on the Filter button label. Core translations are considered safe, and this label is not escaped in any other instance.

Props whyisjake, SergeyBiryukov.
Fixes #40188.

git-svn-id: https://develop.svn.wordpress.org/trunk@48722 602fd350-edb4-49c9-b593-d223f7449a82
---
 src/wp-admin/includes/class-wp-comments-list-table.php | 5 +++--
 src/wp-admin/includes/class-wp-links-list-table.php    | 2 ++
 src/wp-admin/includes/class-wp-ms-sites-list-table.php | 2 ++
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/wp-admin/includes/class-wp-comments-list-table.php b/src/wp-admin/includes/class-wp-comments-list-table.php
index eed0a795f0..6dfd67d466 100644
--- a/src/wp-admin/includes/class-wp-comments-list-table.php
+++ b/src/wp-admin/includes/class-wp-comments-list-table.php
@@ -397,6 +397,7 @@ class WP_Comments_List_Table extends WP_List_Table {
 			ob_start();
 
 			$this->comment_status_dropdown( $comment_type );
+
 			/**
 			 * Fires just before the Filter submit button for comment types.
 			 *
@@ -406,9 +407,9 @@ class WP_Comments_List_Table extends WP_List_Table {
 
 			$output = ob_get_clean();
 
-			if ( ! empty( $output ) && $this->has_items() ) {
+			if ( ! empty( $output ) && $has_items ) {
 				echo $output;
-				submit_button( esc_html__( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
+				submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
 			}
 		}
 
diff --git a/src/wp-admin/includes/class-wp-links-list-table.php b/src/wp-admin/includes/class-wp-links-list-table.php
index e5962b5bec..ae7b56a302 100644
--- a/src/wp-admin/includes/class-wp-links-list-table.php
+++ b/src/wp-admin/includes/class-wp-links-list-table.php
@@ -115,7 +115,9 @@ class WP_Links_List_Table extends WP_List_Table {
 			);
 
 			echo '<label class="screen-reader-text" for="cat_id">' . __( 'Filter by category' ) . '</label>';
+
 			wp_dropdown_categories( $dropdown_options );
+
 			submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
 			?>
 		</div>
diff --git a/src/wp-admin/includes/class-wp-ms-sites-list-table.php b/src/wp-admin/includes/class-wp-ms-sites-list-table.php
index 3b3c7a88a6..50ba8f32ef 100644
--- a/src/wp-admin/includes/class-wp-ms-sites-list-table.php
+++ b/src/wp-admin/includes/class-wp-ms-sites-list-table.php
@@ -332,7 +332,9 @@ class WP_MS_Sites_List_Table extends WP_List_Table {
 			 * @param string $which The location of the extra table nav markup: 'top' or 'bottom'.
 			 */
 			do_action( 'restrict_manage_sites', $which );
+
 			$output = ob_get_clean();
+
 			if ( ! empty( $output ) ) {
 				echo $output;
 				submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'site-query-submit' ) );