From 2599e1b4fb2e0ade2affb580053a4d3379091467 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Tue, 11 Feb 2020 16:34:09 +0000 Subject: [PATCH] Customize: Avoid unnecessary `get_theme_mod()` call and premature escaping in `get_header_video_url()`. The result is still escaped with `esc_url_raw()` for retrieval, and with `esc_url()` for display in `the_header_video_url()`. Props dlh, Tkama. Fixes #40044. git-svn-id: https://develop.svn.wordpress.org/trunk@47267 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/theme.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/theme.php b/src/wp-includes/theme.php index c158b51969..c7c4c3ca63 100644 --- a/src/wp-includes/theme.php +++ b/src/wp-includes/theme.php @@ -1427,12 +1427,13 @@ function has_header_video() { * @return string|false Header video URL or false if there is no video. */ function get_header_video_url() { - $id = absint( get_theme_mod( 'header_video' ) ); - $url = esc_url( get_theme_mod( 'external_header_video' ) ); + $id = absint( get_theme_mod( 'header_video' ) ); if ( $id ) { // Get the file URL from the attachment ID. $url = wp_get_attachment_url( $id ); + } else { + $url = get_theme_mod( 'external_header_video' ); } /**