From 27cee0b0d1818b8d1dee27fa693264b8cf8105ae Mon Sep 17 00:00:00 2001 From: Jb Audras Date: Tue, 27 Jun 2023 10:43:32 +0000 Subject: [PATCH] Twenty Nineteen: Always set background color and foreground color together. On the `` element, as a best practice background color and text color should always be set together. This makes it easier to quickly understand the underlying color scheme. Follow-up to [55960], [55964]. Props sabernhardt, audrasjb, kebbet. Fixes #45916. git-svn-id: https://develop.svn.wordpress.org/trunk@56062 602fd350-edb4-49c9-b593-d223f7449a82 --- .../themes/twentynineteen/sass/elements/_elements.scss | 4 ---- .../themes/twentynineteen/sass/typography/_typography.scss | 1 + src/wp-content/themes/twentynineteen/style-rtl.css | 5 +---- src/wp-content/themes/twentynineteen/style.css | 5 +---- 4 files changed, 3 insertions(+), 12 deletions(-) diff --git a/src/wp-content/themes/twentynineteen/sass/elements/_elements.scss b/src/wp-content/themes/twentynineteen/sass/elements/_elements.scss index edc11cdf91..d3120526b6 100644 --- a/src/wp-content/themes/twentynineteen/sass/elements/_elements.scss +++ b/src/wp-content/themes/twentynineteen/sass/elements/_elements.scss @@ -16,10 +16,6 @@ html { box-sizing: inherit; } -body { - background-color: $color__background-body; -} - a { @include link-transition; color: $color__link; diff --git a/src/wp-content/themes/twentynineteen/sass/typography/_typography.scss b/src/wp-content/themes/twentynineteen/sass/typography/_typography.scss index 055b7a63d4..84438b2efa 100644 --- a/src/wp-content/themes/twentynineteen/sass/typography/_typography.scss +++ b/src/wp-content/themes/twentynineteen/sass/typography/_typography.scss @@ -6,6 +6,7 @@ html { body { -webkit-font-smoothing: antialiased; -moz-osx-font-smoothing: grayscale; + background-color: $color__background-body; color: $color__text-main; @include font-family( $font__body ); font-weight: 400; diff --git a/src/wp-content/themes/twentynineteen/style-rtl.css b/src/wp-content/themes/twentynineteen/style-rtl.css index cab1ba0dcc..aa6b58a191 100644 --- a/src/wp-content/themes/twentynineteen/style-rtl.css +++ b/src/wp-content/themes/twentynineteen/style-rtl.css @@ -2219,6 +2219,7 @@ html { body { -webkit-font-smoothing: antialiased; -moz-osx-font-smoothing: grayscale; + background-color: #fff; color: #111; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: 400; @@ -2493,10 +2494,6 @@ html { box-sizing: inherit; } -body { - background-color: #fff; -} - a { transition: color 110ms ease-in-out; color: #0073aa; diff --git a/src/wp-content/themes/twentynineteen/style.css b/src/wp-content/themes/twentynineteen/style.css index e43f6647c7..64a33800bc 100644 --- a/src/wp-content/themes/twentynineteen/style.css +++ b/src/wp-content/themes/twentynineteen/style.css @@ -2219,6 +2219,7 @@ html { body { -webkit-font-smoothing: antialiased; -moz-osx-font-smoothing: grayscale; + background-color: #fff; color: #111; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: 400; @@ -2493,10 +2494,6 @@ html { box-sizing: inherit; } -body { - background-color: #fff; -} - a { transition: color 110ms ease-in-out; color: #0073aa;