From 283fa473e6a934eef08abe84f73bbb20553e8c66 Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Wed, 16 Jul 2014 22:49:53 +0000 Subject: [PATCH] In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text. Props joedolson. Fixes #28853. git-svn-id: https://develop.svn.wordpress.org/trunk@29201 602fd350-edb4-49c9-b593-d223f7449a82 --- .../includes/class-wp-plugin-install-list-table.php | 8 ++++---- src/wp-admin/js/plugin-install.js | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/wp-admin/includes/class-wp-plugin-install-list-table.php b/src/wp-admin/includes/class-wp-plugin-install-list-table.php index 706af04772..9454a0f29e 100644 --- a/src/wp-admin/includes/class-wp-plugin-install-list-table.php +++ b/src/wp-admin/includes/class-wp-plugin-install-list-table.php @@ -259,13 +259,13 @@ class WP_Plugin_Install_List_Table extends WP_List_Table { switch ( $status['status'] ) { case 'install': if ( $status['url'] ) { - $action_links[] = '' . __( 'Install Now' ) . ''; + $action_links[] = '' . __( 'Install Now' ) . ''; } break; case 'update_available': if ( $status['url'] ) { - $action_links[] = '' . __( 'Update Now' ) . ''; + $action_links[] = '' . __( 'Update Now' ) . ''; } break; @@ -279,8 +279,8 @@ class WP_Plugin_Install_List_Table extends WP_List_Table { $details_link = self_admin_url( 'plugin-install.php?tab=plugin-information&plugin=' . $plugin['slug'] . '&TB_iframe=true&width=600&height=550' ); - $action_links[] = '' . __( 'More Details' ) . ''; + $action_links[] = '' . __( 'More Details' ) . ''; + /** * Filter the install action links for a plugin. diff --git a/src/wp-admin/js/plugin-install.js b/src/wp-admin/js/plugin-install.js index 3a434152ae..837a59fc46 100644 --- a/src/wp-admin/js/plugin-install.js +++ b/src/wp-admin/js/plugin-install.js @@ -38,11 +38,11 @@ jQuery( document ).ready( function( $ ) { tb_position(); }); - $('.plugins').on( 'click', 'a.thickbox', function() { + $('.plugin-card').on( 'click', 'a.thickbox', function() { tb_click.call(this); $('#TB_title').css({'background-color':'#222','color':'#cfcfcf'}); - $('#TB_ajaxWindowTitle').html('' + plugininstallL10n.plugin_information + ' ' + $(this).attr('title') ); + $('#TB_ajaxWindowTitle').html('' + plugininstallL10n.plugin_information + ' ' + $(this).data( 'title' ) ); return false; });