From 2894423f19cc2523458575ccaf0082ce6aaa0d64 Mon Sep 17 00:00:00 2001 From: John Blackbourn Date: Sun, 20 Sep 2015 16:37:41 +0000 Subject: [PATCH] Revisions are an exception when it comes to the editing UI. The `revision` post type cannot have its `show_ui` argument set to true because this allows access to the post type listing, creation, and editing UI, but `get_edit_post_link()` needs to return a URL for the editing UI for revisions as that's how the revisions UI works. Fixes #33763 git-svn-id: https://develop.svn.wordpress.org/trunk@34357 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/link-template.php | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/link-template.php b/src/wp-includes/link-template.php index 49dcdf5309..4cdc9384a9 100644 --- a/src/wp-includes/link-template.php +++ b/src/wp-includes/link-template.php @@ -1221,7 +1221,8 @@ function get_preview_post_link( $post = null, $query_args = array(), $preview_li * * @param int $id Optional. Post ID. * @param string $context Optional, defaults to display. How to write the '&', defaults to '&'. - * @return string|void The edit post link for the given post. + * @return string|null The edit post link for the given post. null if the post type is invalid or does + * not allow an editing UI. */ function get_edit_post_link( $id = 0, $context = 'display' ) { if ( ! $post = get_post( $id ) ) @@ -1241,7 +1242,13 @@ function get_edit_post_link( $id = 0, $context = 'display' ) { if ( !current_user_can( 'edit_post', $post->ID ) ) return; - if ( ! in_array( $post->post_type, get_post_types( array( 'show_ui' => true ) ) ) ) { + $allowed = array_merge( array( + 'revision', + ), get_post_types( array( + 'show_ui' => true, + ) ) ); + + if ( ! in_array( $post->post_type, $allowed ) ) { return; }