From 2967c438910a853d3189c85f2c4820cfe3968f25 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Wed, 7 Jun 2023 06:38:10 +0000 Subject: [PATCH] Coding Standards: Use strict comparison in `wp-includes/class-wp-http-streams.php`. Follow-up to [12424], [25224], [25303], [29852], [45667], [47808], [51825]. Props aristath, poena, afercia, SergeyBiryukov. See #57839. git-svn-id: https://develop.svn.wordpress.org/trunk@55886 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/class-wp-http-streams.php | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/wp-includes/class-wp-http-streams.php b/src/wp-includes/class-wp-http-streams.php index b0dc302a39..9ce881a2f1 100644 --- a/src/wp-includes/class-wp-http-streams.php +++ b/src/wp-includes/class-wp-http-streams.php @@ -126,8 +126,13 @@ class WP_Http_Streams { ) ); - $timeout = (int) floor( $parsed_args['timeout'] ); - $utimeout = $timeout == $parsed_args['timeout'] ? 0 : 1000000 * $parsed_args['timeout'] % 1000000; + $timeout = (int) floor( $parsed_args['timeout'] ); + $utimeout = 0; + + if ( $timeout !== (int) $parsed_args['timeout'] ) { + $utimeout = 1000000 * $parsed_args['timeout'] % 1000000; + } + $connect_timeout = max( $timeout, 1 ); // Store error number. @@ -217,8 +222,8 @@ class WP_Http_Streams { $include_port_in_host_header = ( ( $proxy->is_enabled() && $proxy->send_through_proxy( $url ) ) - || ( 'http' === $parsed_url['scheme'] && 80 != $parsed_url['port'] ) - || ( 'https' === $parsed_url['scheme'] && 443 != $parsed_url['port'] ) + || ( 'http' === $parsed_url['scheme'] && 80 !== $parsed_url['port'] ) + || ( 'https' === $parsed_url['scheme'] && 443 !== $parsed_url['port'] ) ); if ( $include_port_in_host_header ) { @@ -320,7 +325,7 @@ class WP_Http_Streams { $bytes_written_to_file = fwrite( $stream_handle, $block ); - if ( $bytes_written_to_file != $this_block_size ) { + if ( $bytes_written_to_file !== $this_block_size ) { fclose( $handle ); fclose( $stream_handle ); return new WP_Error( 'http_request_failed', __( 'Failed to write request to temporary file.' ) );