vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-16 23:00:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Allow attachment taxonomies to be fetched as objects.

Browse Source 
By adding the `$output` parameter to `get_attachment_taxonomies()`, the
function signature matches that of `get_object_taxonomies()`. The change
also allows for more consistent behavior when passing `output=objects`
to `get_object_taxonomies()` for the 'attachment' object type, since
the `$output` parameter is now passed through the function stack.

Props codemovement.pk.
See #37368.

git-svn-id: https://develop.svn.wordpress.org/trunk@38292 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2016-08-20 17:34:13 +00:00
parent 773eb46bf8
commit 29a5d46701
4 changed files with 66 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/media/getAttachmentTaxonomies.php
+19
View File
@@ -79,4 +79,23 @@ class Tests_Media_GetAttachmentTaxonomies extends WP_UnitTestCase {
$this->assertSame( $expected, $found );
}
/**
* @ticket 37368
*/
public function test_should_respect_output_objects() {
register_taxonomy( 'wptests_tax2', 'attachment:image' );
$a = self::factory()->attachment->create_object( 'image.jpg', 0, array(
'post_mime_type' => 'image/jpeg',
'post_type' => 'attachment'
) );
$attachment = get_post( $a );
$found = get_attachment_taxonomies( $attachment, 'objects' );
$this->assertSame( array( 'wptests_tax2' ), array_keys( $found ) );
$this->assertInternalType( 'object', $found['wptests_tax2'] );
$this->assertSame( 'wptests_tax2', $found['wptests_tax2']->name );
}
}
tests/phpunit/tests/taxonomy/getObjectTaxonomies.php
+36
View File
@@ -45,4 +45,40 @@ class Tests_Taxonomy_GetObjectTaxonomies extends WP_UnitTestCase {
$this->assertSame( $expected, $found );
}
/**
* @ticket 37368
*/
public function test_should_return_all_attachment_taxonomies_for_attachment_object_type() {
register_taxonomy( 'wptests_tax2', 'attachment:image' );
$a = self::factory()->attachment->create_object( 'image.jpg', 0, array(
'post_mime_type' => 'image/jpeg',
'post_type' => 'attachment'
) );
$attachment = get_post( $a );
$found = get_object_taxonomies( $attachment, 'names' );
$this->assertSame( array( 'wptests_tax2' ), $found );
}
/**
* @ticket 37368
*/
public function test_should_respect_output_objects_when_object_is_attachment() {
register_taxonomy( 'wptests_tax2', 'attachment:image' );
$a = self::factory()->attachment->create_object( 'image.jpg', 0, array(
'post_mime_type' => 'image/jpeg',
'post_type' => 'attachment'
) );
$attachment = get_post( $a );
$found = get_object_taxonomies( $attachment, 'objects' );
$this->assertSame( array( 'wptests_tax2' ), array_keys( $found ) );
$this->assertInternalType( 'object', $found['wptests_tax2'] );
$this->assertSame( 'wptests_tax2', $found['wptests_tax2']->name );
}
}