From 2a13d9321c48a3f55aebc5682e944812b969aee8 Mon Sep 17 00:00:00 2001 From: Colin Stewart Date: Sun, 10 Sep 2023 07:31:47 +0000 Subject: [PATCH] Upgrade/Install: Fix broken `sprintf()` call when deleting a backup. In `WP_Upgrader::delete_temp_backup()`, a malformed `sprintf()` call did not pass the value, triggering a Warning in PHP 7 and a Fatal Error in PHP 8. This fixes the malformed `sprintf()` call by correctly passing the value. Follow-up to [55720]. Props akihiroharai, afragen. Fixes #59320. git-svn-id: https://develop.svn.wordpress.org/trunk@56550 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/class-wp-upgrader.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/wp-admin/includes/class-wp-upgrader.php b/src/wp-admin/includes/class-wp-upgrader.php index 69ba518328..1fbfa99e4c 100644 --- a/src/wp-admin/includes/class-wp-upgrader.php +++ b/src/wp-admin/includes/class-wp-upgrader.php @@ -1207,8 +1207,7 @@ class WP_Upgrader { if ( ! $wp_filesystem->delete( $temp_backup_dir, true ) ) { $errors->add( 'temp_backup_delete_failed', - sprintf( $this->strings['temp_backup_delete_failed'] ), - $args['slug'] + sprintf( $this->strings['temp_backup_delete_failed'], $args['slug'] ) ); continue; }