From 2b08bfb954ebf4a6d983ea038debf06723f94175 Mon Sep 17 00:00:00 2001
From: Sergey Biryukov <sergeybiryukov@git.wordpress.org>
Date: Sun, 11 Feb 2018 14:16:43 +0000
Subject: [PATCH] Media: Convert concatenation in `img_caption_shortcode()` to
 `sprintf()` for clarity.

See #34595.

git-svn-id: https://develop.svn.wordpress.org/trunk@42690 602fd350-edb4-49c9-b593-d223f7449a82
---
 src/wp-includes/media.php | 26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php
index 7bfda66f1c..24c370769d 100644
--- a/src/wp-includes/media.php
+++ b/src/wp-includes/media.php
@@ -1589,11 +1589,29 @@ function img_caption_shortcode( $attr, $content = null ) {
 	}
 
 	if ( $html5 ) {
-		$html = '<figure ' . $atts['id'] . $style . 'class="' . esc_attr( $class ) . '">'
-		. do_shortcode( $content ) . '<figcaption class="wp-caption-text">' . $atts['caption'] . '</figcaption></figure>';
+		$html = sprintf(
+			'<figure %s%sclass="%s">%s%s</figure>',
+			$atts['id'],
+			$style,
+			esc_attr( $class ),
+			do_shortcode( $content ),
+			sprintf(
+				'<figcaption class="wp-caption-text">%s</figcaption>',
+				$atts['caption']
+			)
+		);
 	} else {
-		$html = '<div ' . $atts['id'] . $style . 'class="' . esc_attr( $class ) . '">'
-		. do_shortcode( $content ) . '<p class="wp-caption-text">' . $atts['caption'] . '</p></div>';
+		$html = sprintf(
+			'<div %s%sclass="%s">%s%s</div>',
+			$atts['id'],
+			$style,
+			esc_attr( $class ),
+			do_shortcode( $content ),
+			sprintf(
+				'<p class="wp-caption-text">%s</p>',
+				$atts['caption']
+			)
+		);
 	}
 
 	return $html;