From 2b3bf409072e21cd6e220feb0eb2bcf48e72ec88 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Wed, 19 Aug 2020 01:57:29 +0000 Subject: [PATCH] Comments: Revert unintended changes from [48822]. See #51044. git-svn-id: https://develop.svn.wordpress.org/trunk@48823 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/misc.php | 42 +++++++++++++++++----------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/wp-admin/includes/misc.php b/src/wp-admin/includes/misc.php index 80e0b395ff..68cdd4800a 100644 --- a/src/wp-admin/includes/misc.php +++ b/src/wp-admin/includes/misc.php @@ -688,6 +688,8 @@ function set_screen_options() { } break; default: + $screen_option = false; + if ( '_page' === substr( $option, -5 ) || 'layout_columns' === $option ) { /** * Filters a screen option value before it is set. @@ -708,29 +710,27 @@ function set_screen_options() { * @param string $option The option name. * @param int $value The option value. */ - $value = apply_filters( 'set-screen-option', false, $option, $value ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores - } else { - /** - * Filters a screen option value before it is set. - * - * The dynamic portion of the hook, `$option`, refers to the option name. - * - * Returning false from the filter will skip saving the current option. - * - * @since 5.4.2 - * @since 5.4.3 Only applied to options not ending with '_page', - * and not the 'layout_columns' option. - * - * @see set_screen_options() - * - * @param mixed $screen_option The value to save instead of the option value. - * Default false (to skip saving the current option). - * @param string $option The option name. - * @param int $value The option value. - */ - $value = apply_filters( "set_screen_option_{$option}", false, $option, $value ); + $screen_option = apply_filters( 'set-screen-option', $screen_option, $option, $value ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores } + /** + * Filters a screen option value before it is set. + * + * The dynamic portion of the hook, `$option`, refers to the option name. + * + * Returning false from the filter will skip saving the current option. + * + * @since 5.4.2 + * + * @see set_screen_options() + * + * @param mixed $screen_option The value to save instead of the option value. + * Default false (to skip saving the current option). + * @param string $option The option name. + * @param int $value The option value. + */ + $value = apply_filters( "set_screen_option_{$option}", $screen_option, $option, $value ); + if ( false === $value ) { return; }