From 2d3a51d16cf7618a805d452ec9d55dbaa9d5b5be Mon Sep 17 00:00:00 2001 From: Lance Willett Date: Mon, 30 Mar 2015 22:48:11 +0000 Subject: [PATCH] Twenty Fifteen: adjust scroll behavior to make sure sidebar height is calculated during scroll events, not just resize events. Fixes #31734. Props jartes, lancewillett. git-svn-id: https://develop.svn.wordpress.org/trunk@31934 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-content/themes/twentyfifteen/functions.php | 2 +- src/wp-content/themes/twentyfifteen/js/functions.js | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/wp-content/themes/twentyfifteen/functions.php b/src/wp-content/themes/twentyfifteen/functions.php index d96c0270b3..1a8e8a3a38 100644 --- a/src/wp-content/themes/twentyfifteen/functions.php +++ b/src/wp-content/themes/twentyfifteen/functions.php @@ -250,7 +250,7 @@ function twentyfifteen_scripts() { wp_enqueue_script( 'twentyfifteen-keyboard-image-navigation', get_template_directory_uri() . '/js/keyboard-image-navigation.js', array( 'jquery' ), '20141010' ); } - wp_enqueue_script( 'twentyfifteen-script', get_template_directory_uri() . '/js/functions.js', array( 'jquery' ), '20141212', true ); + wp_enqueue_script( 'twentyfifteen-script', get_template_directory_uri() . '/js/functions.js', array( 'jquery' ), '20150330', true ); wp_localize_script( 'twentyfifteen-script', 'screenReaderText', array( 'expand' => '' . __( 'expand child menu', 'twentyfifteen' ) . '', 'collapse' => '' . __( 'collapse child menu', 'twentyfifteen' ) . '', diff --git a/src/wp-content/themes/twentyfifteen/js/functions.js b/src/wp-content/themes/twentyfifteen/js/functions.js index 558869ac61..eeeecd2246 100644 --- a/src/wp-content/themes/twentyfifteen/js/functions.js +++ b/src/wp-content/themes/twentyfifteen/js/functions.js @@ -80,10 +80,7 @@ // Sidebar scrolling. function resize() { - windowWidth = $window.width(); - windowHeight = $window.height(); - bodyHeight = $body.height(); - sidebarHeight = $sidebar.height(); + windowWidth = $window.width(); if ( 955 > windowWidth ) { top = bottom = false; @@ -98,6 +95,10 @@ return; } + sidebarHeight = $sidebar.height(); + windowHeight = $window.height(); + bodyHeight = $body.height(); + if ( sidebarHeight + adminbarOffset > windowHeight ) { if ( windowPos > lastWindowPos ) { if ( top ) {