From 2d9f3a133083fa52a662fb8f9091e002eac46152 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Mon, 17 Feb 2020 03:22:43 +0000 Subject: [PATCH] REST API: Restore `wp-admin/includes/image.php` requirement in `WP_REST_Attachments_Controller::create_item()`. Although the file is already included via the `::insert_attachment()` method, this addresses an inconsistency and corrects a misleading comment. It also reduces the possibility of a future error in case `::insert_attachment()` is no longer called earlier in `::create_item()` at some point. Follow-up to [43850] and [44206]. Props luisrivera. Fixes #49449. git-svn-id: https://develop.svn.wordpress.org/trunk@47296 602fd350-edb4-49c9-b593-d223f7449a82 --- .../endpoints/class-wp-rest-attachments-controller.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php b/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php index 59cb3ed182..eba5fa1388 100644 --- a/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php +++ b/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php @@ -185,8 +185,9 @@ class WP_REST_Attachments_Controller extends WP_REST_Posts_Controller { header( 'X-WP-Upload-Attachment-ID: ' . $attachment_id ); } - // Include media functions to get access to wp_generate_attachment_metadata(). + // Include media and image functions to get access to wp_generate_attachment_metadata(). require_once ABSPATH . 'wp-admin/includes/media.php'; + require_once ABSPATH . 'wp-admin/includes/image.php'; // Post-process the upload (create image sub-sizes, make PDF thumbnalis, etc.) and insert attachment meta. // At this point the server may run out of resources and post-processing of uploaded images may fail.