From 2daa4b6c82f7314c676292550c64ce644e50d767 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Sun, 12 Jan 2020 14:16:57 +0000 Subject: [PATCH] Tests: In `Tests_Site_Health`, create a `WP_Site_Health` instance before clearing the cron array, as the constructor schedules its own task now. See #47606. git-svn-id: https://develop.svn.wordpress.org/trunk@47064 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/site-health.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/phpunit/tests/site-health.php b/tests/phpunit/tests/site-health.php index 6c22fe4ddf..7609dc3c66 100644 --- a/tests/phpunit/tests/site-health.php +++ b/tests/phpunit/tests/site-health.php @@ -15,10 +15,12 @@ class Tests_Site_Health extends WP_UnitTestCase { * @ticket 47223 */ function test_cron_health_checks_critical() { + $wp_site_health = new WP_Site_Health(); + // Clear the cron array. _set_cron_array( array() ); - $wp_site_health = new WP_Site_Health(); - $cron_health = $wp_site_health->get_test_scheduled_events(); + + $cron_health = $wp_site_health->get_test_scheduled_events(); $this->assertSame( 'critical', $cron_health['status'] ); $this->assertSame( __( 'It was not possible to check your scheduled events' ), $cron_health['label'] ); @@ -33,6 +35,8 @@ class Tests_Site_Health extends WP_UnitTestCase { * @ticket 47223 */ function test_cron_health_checks( $times, $expected_status, $expected_label, $expected_late, $expected_missed ) { + $wp_site_health = new WP_Site_Health(); + /* * Clear the cron array. * @@ -47,8 +51,7 @@ class Tests_Site_Health extends WP_UnitTestCase { wp_schedule_event( $timestamp, 'daily', __FUNCTION__ . "_{$job}" ); } - $wp_site_health = new WP_Site_Health(); - $cron_health = $wp_site_health->get_test_scheduled_events(); + $cron_health = $wp_site_health->get_test_scheduled_events(); $this->assertSame( $expected_status, $cron_health['status'] ); $this->assertSame( $expected_label, $cron_health['label'] );