vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 22:30:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Comments: Always lazily load comment meta.

Browse Source 
In [34270] introduced lazy loading of comment meta. However, this was only in the context of `WP_Query`. Other parts of the codebase, like `WP_Comment_Query` did not lazily load comment meta. In this change, calls to `update_meta_cache` are now replaced with `wp_lazyload_comment_meta`, that instead of priming comment meta caches, just adds them to the queue to be primed it ever called. This results in far less database queries, as there a number of places where comment meta is being primed unnecessarily and never used. Adding everything to the comment meta queue, also means that if comment meta is used, that is all loaded in a single database / cache call.

Follow on from [55671], [55747].

Props spacedmonkey, peterwilsoncc, flixos90, mukesh27.
Fixes #57801.

git-svn-id: https://develop.svn.wordpress.org/trunk@55749 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jonny Harris
2023-05-11 12:25:51 +00:00
parent 1534d12067
commit 3114eda235
6 changed files with 124 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

95
tests/phpunit/tests/comment/metaCache.php
View File

@@ -11,7 +11,7 @@ class Tests_Comment_MetaCache extends WP_UnitTestCase {
*
* @covers ::update_comment_meta
*/
public function test_update_comment_meta_cache_should_default_to_true() {
public function test_update_comment_meta_cache_should_default_to_lazy_loading() {
$p = self::factory()->post->create( array( 'post_status' => 'publish' ) );
$comment_ids = self::factory()->comment->create_post_comments( $p, 3 );
@@ -22,18 +22,55 @@ class Tests_Comment_MetaCache extends WP_UnitTestCase {
// Clear comment cache, just in case.
clean_comment_cache( $comment_ids );
$q = new WP_Comment_Query(
$num_queries = get_num_queries();
$q = new WP_Comment_Query(
array(
'post_ID' => $p,
)
);
$this->assertSame( 2, get_num_queries() - $num_queries, 'Querying comments is expected to make two queries' );
$num_queries = get_num_queries();
foreach ( $comment_ids as $cid ) {
get_comment_meta( $cid, 'foo', 'bar' );
}
$this->assertSame( $num_queries, get_num_queries() );
$this->assertSame( 1, get_num_queries() - $num_queries, 'Querying comments is expected to make two queries' );
}
/**
* @ticket 57801
*
* @covers ::wp_lazyload_comment_meta
*/
public function test_update_comment_meta_cache_should_default_to_lazy_loading_fields_id() {
$p = self::factory()->post->create( array( 'post_status' => 'publish' ) );
$comment_ids = self::factory()->comment->create_post_comments( $p, 3 );
foreach ( $comment_ids as $cid ) {
update_comment_meta( $cid, 'foo', 'bar' );
}
// Clear comment cache, just in case.
clean_comment_cache( $comment_ids );
$num_queries = get_num_queries();
$q = new WP_Comment_Query(
array(
'post_ID' => $p,
'fields' => 'ids',
)
);
$this->assertSame( 1, get_num_queries() - $num_queries, 'Querying comments is expected to make two queries' );
$num_queries = get_num_queries();
foreach ( $comment_ids as $cid ) {
get_comment_meta( $cid, 'foo', 'bar' );
}
$this->assertSame( 1, get_num_queries() - $num_queries, 'Comment meta is expected to be lazy loaded' );
}
/**
@@ -52,19 +89,59 @@ class Tests_Comment_MetaCache extends WP_UnitTestCase {
// Clear comment cache, just in case.
clean_comment_cache( $comment_ids );
$q = new WP_Comment_Query(
$num_queries = get_num_queries();
$q = new WP_Comment_Query(
array(
'post_ID' => $p,
'update_comment_meta_cache' => true,
)
);
$this->assertSame( 2, get_num_queries() - $num_queries, 'Comments should be queries and primed in two database queries' );
$num_queries = get_num_queries();
foreach ( $comment_ids as $cid ) {
get_comment_meta( $cid, 'foo', 'bar' );
}
$this->assertSame( $num_queries, get_num_queries() );
$this->assertSame( 1, get_num_queries() - $num_queries, 'Comment meta should be loaded in one database query' );
}
/**
* @ticket 57801
*
* @covers ::update_comment_meta
*/
public function test_update_comment_meta_cache_true_multiple() {
$posts = self::factory()->post->create_many( 3 );
$all_comment_ids = array();
foreach ( $posts as $p ) {
$comment_ids = self::factory()->comment->create_post_comments( $p, 3 );
foreach ( $comment_ids as $cid ) {
update_comment_meta( $cid, 'foo', 'bar' );
$all_comment_ids[] = $cid;
}
$num_queries = get_num_queries();
$q = new WP_Comment_Query(
array(
'post_ID' => $p,
'update_comment_meta_cache' => true,
)
);
$this->assertSame( 1, get_num_queries() - $num_queries, 'Comment query should only add one query' );
}
$filter = new MockAction();
add_filter( 'update_comment_metadata_cache', array( $filter, 'filter' ), 10, 2 );
$num_queries = get_num_queries();
get_comment_meta( $comment_ids[0], 'foo', 'bar' );
$this->assertSame( 1, get_num_queries() - $num_queries, 'Comment meta should be loaded in one database query' );
$args = $filter->get_args();
$first = reset( $args );
$prime_comment_ids = end( $first );
$this->assertSameSets( $prime_comment_ids, $all_comment_ids, 'All comment meta should be loaded all at once' );
}
/**
@@ -92,7 +169,7 @@ class Tests_Comment_MetaCache extends WP_UnitTestCase {
get_comment_meta( $cid, 'foo', 'bar' );
}
$this->assertSame( $num_queries + 3, get_num_queries() );
$this->assertSame( 3, get_num_queries() - $num_queries );
}
/**
@@ -120,12 +197,12 @@ class Tests_Comment_MetaCache extends WP_UnitTestCase {
// First request will hit the database.
$num_queries = get_num_queries();
get_comment_meta( $comment_ids[0], 'sauce' );
$this->assertSame( $num_queries + 1, get_num_queries() );
$this->assertSame( 1, get_num_queries() - $num_queries );
// Second and third requests should be in cache.
get_comment_meta( $comment_ids[1], 'sauce' );
get_comment_meta( $comment_ids[2], 'sauce' );
$this->assertSame( $num_queries + 1, get_num_queries() );
$this->assertSame( 1, get_num_queries() - $num_queries );
}
}
}
@@ -134,6 +211,7 @@ class Tests_Comment_MetaCache extends WP_UnitTestCase {
* @ticket 34047
*
* @covers ::get_comment_meta
* @covers ::wp_lazyload_comment_meta
*/
public function test_comment_meta_should_be_lazy_loaded_in_comment_feed_queries() {
$posts = self::factory()->post->create_many( 2, array( 'post_status' => 'publish' ) );
@@ -182,6 +260,7 @@ class Tests_Comment_MetaCache extends WP_UnitTestCase {
* @ticket 34047
*
* @covers ::get_comment_meta
* @covers ::wp_lazyload_comment_meta
*/
public function test_comment_meta_should_be_lazy_loaded_in_single_post_comment_feed_queries() {
$posts = self::factory()->post->create_many( 2, array( 'post_status' => 'publish' ) );