vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-05-30 08:00:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Explicitly mark empty REST API tests as not performing any assertions.

Browse Source 
WordPress core test suite uses PHPUnit's `beStrictAboutTestsThatDoNotTestAnything` option set to true, which marks a test as risky when no assertions are performed.

REST API test classes have some empty tests for non-implemented methods because these test classes extend the abstract `WP_Test_REST_Controller_Testcase` class, which requires several methods to be implemented that don't necessarily make sense for all REST API routes.

As these tests are intentionally empty, they were previously marked as skipped, so that they are not reported as risky.

This commit aims to further reduce noise in the test suite and effectively ignores these empty tests altogether, which seems like a more appropriate option at this time.

The `@doesNotPerformAssertions` annotation can be reconsidered in the future when the tests are either removed as unnecessary or updated to actually perform assertions related to their behavior.

Follow-up to [40534], [41176], [41228], [53921].

See #40538, #41463, #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@54058 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2022-09-01 22:54:19 +00:00
parent c4594ec05b
commit 32ead26653
18 changed files with 265 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/phpunit/tests/rest-api/rest-pattern-directory-controller.php
View File

@@ -310,20 +310,32 @@ class WP_REST_Pattern_Directory_Controller_Test extends WP_Test_REST_Controller_
$this->assertSame( 'modified the cache', $patterns[0] );
}
/**
* @doesNotPerformAssertions
*/
public function test_get_item() {
$this->markTestSkipped( 'Controller does not implement get_item().' );
// Controller does not implement get_item().
}
/**
* @doesNotPerformAssertions
*/
public function test_create_item() {
$this->markTestSkipped( 'Controller does not implement create_item().' );
// Controller does not implement create_item().
}
/**
* @doesNotPerformAssertions
*/
public function test_update_item() {
$this->markTestSkipped( 'Controller does not implement update_item().' );
// Controller does not implement update_item().
}
/**
* @doesNotPerformAssertions
*/
public function test_delete_item() {
$this->markTestSkipped( 'Controller does not implement delete_item().' );
// Controller does not implement delete_item().
}
/**
@@ -402,9 +414,11 @@ class WP_REST_Pattern_Directory_Controller_Test extends WP_Test_REST_Controller_
* @covers WP_REST_Pattern_Directory_Controller::get_item_schema
*
* @since 5.8.0
*
* @doesNotPerformAssertions
*/
public function test_get_item_schema() {
$this->markTestSkipped( "The controller's schema is hardcoded, so tests would not be meaningful." );
// The controller's schema is hardcoded, so tests would not be meaningful.
}
/**