vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Query: Rename _prime_post_parents_caches() for clarity.

Browse Source 
Change the name of `_prime_post_parents_caches()` to `_prime_post_parent_id_caches()` to make it clearer only the parent post ID is cached rather than the entire post parent object.

Follow up to [56763].

Props spacedmonkey, joemcgill, peterwilsoncc.
See #59188.


git-svn-id: https://develop.svn.wordpress.org/trunk@56811 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Peter Wilson 2023-10-09 23:01:15 +00:00
parent 93cc3b17a0
commit 33b32ebc4e
3 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-includes/class-wp-query.php
View File

@ -3191,7 +3191,7 @@ class WP_Query {
return $this->posts;
} elseif ( 'id=>parent' === $q['fields'] ) {
_prime_post_parents_caches( $post_ids );
_prime_post_parent_id_caches( $post_ids );
/** @var int[] */
$post_parents = wp_cache_get_multiple( $post_ids, 'post_parent' );

4
src/wp-includes/post.php
View File

@ -7797,7 +7797,7 @@ function _prime_post_caches( $ids, $update_term_cache = true, $update_meta_cache
}
/**
* Prime post parent caches.
* Prime the cache containing the parent ID of various post objects.
*
* @global wpdb $wpdb WordPress database abstraction object.
*
@ -7805,7 +7805,7 @@ function _prime_post_caches( $ids, $update_term_cache = true, $update_meta_cache
*
* @param int[] $ids ID list.
*/
function _prime_post_parents_caches( array $ids ) {
function _prime_post_parent_id_caches( array $ids ) {
global $wpdb;
$non_cached_ids = _get_non_cached_ids( $ids, 'post_parent' );

32
tests/phpunit/tests/post/primePostParentsCaches.php
View File

@ -1,19 +1,19 @@
<?php
/**
* Test `_prime_post_parents_caches()`.
* Test `_prime_post_parent_id_caches()`.
*
* @package WordPress
*/
/**
* Test class for `_prime_post_parents_caches()`.
* Test class for `_prime_post_parent_id_caches()`.
*
* @group post
* @group cache
*
* @covers ::_prime_post_parents_caches
* @covers ::_prime_post_parent_id_caches
*/
class Tests_Post_PrimePostParentsCaches extends WP_UnitTestCase {
class Tests_Post_PrimePostParentIdCaches extends WP_UnitTestCase {
/**
* Post IDs.
@ -34,11 +34,11 @@ class Tests_Post_PrimePostParentsCaches extends WP_UnitTestCase {
/**
* @ticket 59188
*/
public function test_prime_post_parents_caches() {
public function test_prime_post_parent_id_caches() {
$post_id = self::$posts[0];
$before_num_queries = get_num_queries();
_prime_post_parents_caches( array( $post_id ) );
_prime_post_parent_id_caches( array( $post_id ) );
$num_queries = get_num_queries() - $before_num_queries;
$this->assertSame( 1, $num_queries, 'Unexpected number of queries.' );
@ -48,9 +48,9 @@ class Tests_Post_PrimePostParentsCaches extends WP_UnitTestCase {
/**
* @ticket 59188
*/
public function test_prime_post_parents_caches_multiple() {
public function test_prime_post_parent_id_caches_multiple() {
$before_num_queries = get_num_queries();
_prime_post_parents_caches( self::$posts );
_prime_post_parent_id_caches( self::$posts );
$num_queries = get_num_queries() - $before_num_queries;
$this->assertSame( 1, $num_queries, 'Unexpected number of queries.' );
@ -60,10 +60,10 @@ class Tests_Post_PrimePostParentsCaches extends WP_UnitTestCase {
/**
* @ticket 59188
*/
public function test_prime_post_parents_caches_multiple_runs() {
_prime_post_parents_caches( self::$posts );
public function test_prime_post_parent_id_caches_multiple_runs() {
_prime_post_parent_id_caches( self::$posts );
$before_num_queries = get_num_queries();
_prime_post_parents_caches( self::$posts );
_prime_post_parent_id_caches( self::$posts );
$num_queries = get_num_queries() - $before_num_queries;
$this->assertSame( 0, $num_queries, 'Unexpected number of queries.' );
@ -72,7 +72,7 @@ class Tests_Post_PrimePostParentsCaches extends WP_UnitTestCase {
/**
* @ticket 59188
*/
public function test_prime_post_parents_caches_update() {
public function test_prime_post_parent_id_caches_update() {
$page_id = self::factory()->post->create(
array(
'post_type' => 'page',
@ -80,7 +80,7 @@ class Tests_Post_PrimePostParentsCaches extends WP_UnitTestCase {
)
);
$before_num_queries = get_num_queries();
_prime_post_parents_caches( array( $page_id ) );
_prime_post_parent_id_caches( array( $page_id ) );
$num_queries = get_num_queries() - $before_num_queries;
$this->assertSame( 1, $num_queries, 'Unexpected number of queries on first run' );
@ -94,7 +94,7 @@ class Tests_Post_PrimePostParentsCaches extends WP_UnitTestCase {
);
$before_num_queries = get_num_queries();
_prime_post_parents_caches( array( $page_id ) );
_prime_post_parent_id_caches( array( $page_id ) );
$num_queries = get_num_queries() - $before_num_queries;
$this->assertSame( 1, $num_queries, 'Unexpected number of queries on second run' );
@ -104,7 +104,7 @@ class Tests_Post_PrimePostParentsCaches extends WP_UnitTestCase {
/**
* @ticket 59188
*/
public function test_prime_post_parents_caches_delete() {
public function test_prime_post_parent_id_caches_delete() {
$parent_page_id = self::factory()->post->create(
array(
'post_type' => 'page',
@ -117,7 +117,7 @@ class Tests_Post_PrimePostParentsCaches extends WP_UnitTestCase {
)
);
$before_num_queries = get_num_queries();
_prime_post_parents_caches( array( $page_id ) );
_prime_post_parent_id_caches( array( $page_id ) );
$num_queries = get_num_queries() - $before_num_queries;
$this->assertSame( 1, $num_queries, 'Unexpected number of queries on first run' );