vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-02 11:44:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Post Thumbnails: Change the return value of get_post_thumbnail_id() for a non-existing post to false instead of an empty string.

Browse Source 
This further makes the function more consistent with `get_the_ID()` or `wp_get_post_parent_id()`, both returning `false` for a non-existing post.

Additionally, document that `get_post_thumbnail_id()` returns `0` if the thumbnail image is not set.

Follow-up to [47160].

Props theMikeD, dingo_d, netpassprodsr, SergeyBiryukov.
Fixes #49832. See #40096.

git-svn-id: https://develop.svn.wordpress.org/trunk@48310 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2020-07-05 10:15:40 +00:00
parent 2d36a7640a
commit 34730d2ea0
3 changed files with 22 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/phpunit/tests/post/thumbnails.php
View File

@@ -54,9 +54,9 @@ class Tests_Post_Thumbnail_Template extends WP_UnitTestCase {
}
function test_get_post_thumbnail_id() {
$this->assertEmpty( get_post_thumbnail_id( self::$post ) );
$this->assertEmpty( get_post_thumbnail_id( self::$post->ID ) );
$this->assertEmpty( get_post_thumbnail_id() );
$this->assertSame( 0, get_post_thumbnail_id( self::$post ) );
$this->assertSame( 0, get_post_thumbnail_id( self::$post->ID ) );
$this->assertFalse( get_post_thumbnail_id() );
set_post_thumbnail( self::$post, self::$attachment_id );