vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Taxonomy: Use get_terms instead of a database lookup in term_exists().

Browse Source 
Replace raw SQL queries to the terms table, with a call to the `get_terms` function. Using `get_terms` means that `term_exists` is now cached. For developers using `term_exists` where cache invalidation is disabled, such as importing, a workaround was added to ensure that queries are uncached. 

Props Spacedmonkey, boonebgorges, flixos90, peterwilsoncc. 
Fixes #36949. 


git-svn-id: https://develop.svn.wordpress.org/trunk@52921 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jonny Harris
2022-03-11 11:05:02 +00:00
parent 1bcd722fd6
commit 34d46cd501
5 changed files with 186 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/phpunit/tests/term/getTerm.php
View File

@@ -31,6 +31,8 @@ class Tests_Term_GetTerm extends WP_UnitTestCase {
array( '%d' )
);
clean_term_cache( $t1['term_id'] );
return array(
array(
'term_id' => $t1['term_id'],

6
tests/phpunit/tests/term/splitSharedTerm.php
View File

@@ -54,6 +54,7 @@ class Tests_Term_SplitSharedTerm extends WP_UnitTestCase {
array( '%d' ),
array( '%d' )
);
clean_term_cache( $t1['term_id'], 'category' );
$t2_child = wp_insert_term(
'Foo Child',
@@ -151,6 +152,7 @@ class Tests_Term_SplitSharedTerm extends WP_UnitTestCase {
array( '%d' ),
array( '%d' )
);
clean_term_cache( $t1['term_id'], 'category' );
$th = _get_term_hierarchy( 'wptests_tax_4' );
$new_term_id = _split_shared_term( $t1['term_id'], $t3['term_taxonomy_id'] );
@@ -179,6 +181,7 @@ class Tests_Term_SplitSharedTerm extends WP_UnitTestCase {
array( '%d' ),
array( '%d' )
);
clean_term_cache( $t1['term_id'], 'category' );
$this->assertSame( $t1['term_id'], get_option( 'default_category', -1 ) );
@@ -207,6 +210,7 @@ class Tests_Term_SplitSharedTerm extends WP_UnitTestCase {
array( '%d' ),
array( '%d' )
);
clean_term_cache( $t1['term_id'], 'category' );
$menu_id = wp_create_nav_menu( 'Nav Menu Bar' );
$cat_menu_item = wp_update_nav_menu_item(
@@ -245,6 +249,7 @@ class Tests_Term_SplitSharedTerm extends WP_UnitTestCase {
array( 'term_id' => $shared_term_id ),
array( 'term_taxonomy_id' => $nav_term->term_taxonomy_id )
);
clean_term_cache( $shared_term_id, 'category' );
set_theme_mod( 'nav_menu_locations', array( 'foo' => $shared_term_id ) );
@@ -274,6 +279,7 @@ class Tests_Term_SplitSharedTerm extends WP_UnitTestCase {
array( 'term_id' => $shared_term_id ),
array( 'term_taxonomy_id' => $nav_term->term_taxonomy_id )
);
clean_term_cache( $shared_term_id, 'category' );
$t1 = wp_insert_term( 'Random term', 'category' );
$cat_menu_item = wp_update_nav_menu_item(

126
tests/phpunit/tests/term/termExists.php
View File

@@ -271,6 +271,132 @@ class Tests_TermExists extends WP_UnitTestCase {
_unregister_taxonomy( 'wptests_tax' );
}
/**
* @ticket 36949
* @covers ::term_exists()
*/
public function test_term_lookup_by_id_and_update() {
register_taxonomy( 'wptests_tax', 'post' );
$slug = __FUNCTION__;
$t = self::factory()->term->create(
array(
'slug' => $slug,
'taxonomy' => 'wptests_tax',
)
);
$this->assertEquals( $t, term_exists( $t ) );
$this->assertTrue( wp_delete_term( $t, 'wptests_tax' ) );
$this->assertNull( term_exists( $t ) );
// Clean up.
_unregister_taxonomy( 'wptests_tax' );
}
/**
* @ticket 36949
* @covers ::term_exists()
*/
public function test_term_lookup_by_slug_and_update() {
register_taxonomy( 'wptests_tax', 'post' );
$slug = __FUNCTION__;
$t = self::factory()->term->create(
array(
'slug' => $slug,
'taxonomy' => 'wptests_tax',
)
);
$this->assertEquals( $t, term_exists( $slug ) );
$this->assertTrue( wp_delete_term( $t, 'wptests_tax' ) );
$this->assertNull( term_exists( $slug ) );
// Clean up.
_unregister_taxonomy( 'wptests_tax' );
}
/**
* @ticket 36949
* @covers ::term_exists()
*/
public function test_term_exists_caching() {
global $wpdb;
register_taxonomy( 'wptests_tax', 'post' );
$slug = __FUNCTION__;
$t = self::factory()->term->create(
array(
'slug' => $slug,
'taxonomy' => 'wptests_tax',
)
);
$this->assertEquals( $t, term_exists( $slug ) );
$num_queries = $wpdb->num_queries;
$this->assertEquals( $t, term_exists( $slug ) );
$this->assertSame( $num_queries, $wpdb->num_queries );
$this->assertTrue( wp_delete_term( $t, 'wptests_tax' ) );
$num_queries = $wpdb->num_queries;
$this->assertNull( term_exists( $slug ) );
$this->assertSame( $num_queries + 2, $wpdb->num_queries );
// Clean up.
_unregister_taxonomy( 'wptests_tax' );
}
/**
* @ticket 36949
* @covers ::term_exists()
*/
public function test_term_exists_caching_suspend_cache_invalidation() {
global $wpdb;
register_taxonomy( 'wptests_tax', 'post' );
wp_suspend_cache_invalidation( true );
$slug = __FUNCTION__;
$t = self::factory()->term->create(
array(
'slug' => $slug,
'taxonomy' => 'wptests_tax',
)
);
$this->assertEquals( $t, term_exists( $slug ) );
$num_queries = $wpdb->num_queries;
$this->assertEquals( $t, term_exists( $slug ) );
$this->assertSame( $num_queries + 1, $wpdb->num_queries );
wp_suspend_cache_invalidation( false );
// Clean up.
_unregister_taxonomy( 'wptests_tax' );
}
/**
* @ticket 36949
* @covers ::term_exists()
*/
public function test_term_exists_caching_by_int_suspend_cache_invalidation() {
register_taxonomy( 'wptests_tax', 'post' );
$slug = __FUNCTION__;
$t = self::factory()->term->create(
array(
'slug' => $slug,
'taxonomy' => 'wptests_tax',
)
);
// Warm cache in get_term() via term_exists().
term_exists( $t );
wp_suspend_cache_invalidation( true );
wp_delete_term( $t, 'wptests_tax' );
$this->assertNull( term_exists( $t ) );
// Reneable cache invalidation.
wp_suspend_cache_invalidation( false );
_unregister_taxonomy( 'wptests_tax' );
}
public function test_term_exists_unknown() {
$this->assertNull( term_exists( rand_str() ) );
$this->assertSame( 0, term_exists( 0 ) );

2
tests/phpunit/tests/term/wpGetObjectTerms.php
View File

@@ -447,6 +447,8 @@ class Tests_Term_WpGetObjectTerms extends WP_UnitTestCase {
$wpdb->update( $wpdb->term_taxonomy, array( 'term_taxonomy_id' => 100006 ), array( 'term_taxonomy_id' => $term_2->term_taxonomy_id ) );
$wpdb->update( $wpdb->term_taxonomy, array( 'term_taxonomy_id' => 100005 ), array( 'term_taxonomy_id' => $term_3->term_taxonomy_id ) );
clean_term_cache( array( $t1, $t2, $t3 ), $this->taxonomy );
$set = wp_set_object_terms( $p, array( $t1, $t2, $t3 ), $this->taxonomy );
$found = wp_get_object_terms(