From 36d237cc1342a83b3facb8a70e5c69d752036cdd Mon Sep 17 00:00:00 2001 From: Dion Hulse Date: Mon, 12 Mar 2018 01:56:20 +0000 Subject: [PATCH] Plugins: Add support for plugins having an `active_installs` value larger than 1 million. WordPress.org currently supports up to 5 million, and with the growth of WordPress, it's expected that that upper bound will increase in the future. Fixes #43193. git-svn-id: https://develop.svn.wordpress.org/trunk@42829 602fd350-edb4-49c9-b593-d223f7449a82 --- .../includes/class-wp-plugin-install-list-table.php | 6 +++++- src/wp-admin/includes/plugin-install.php | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/wp-admin/includes/class-wp-plugin-install-list-table.php b/src/wp-admin/includes/class-wp-plugin-install-list-table.php index ceb0558c05..07ee266e09 100644 --- a/src/wp-admin/includes/class-wp-plugin-install-list-table.php +++ b/src/wp-admin/includes/class-wp-plugin-install-list-table.php @@ -650,7 +650,11 @@ class WP_Plugin_Install_List_Table extends WP_List_Table {
= 1000000 ) { - $active_installs_text = _x( '1+ Million', 'Active plugin installations' ); + $active_installs_millions = floor( $plugin['active_installs'] / 1000000 ); + $active_installs_text = sprintf( + _nx( '%s+ Million', '%s+ Million', 'Active plugin installations', $active_installs_millions ), + number_format_i18n( $active_installs_millions ) + ); } elseif ( 0 == $plugin['active_installs'] ) { $active_installs_text = _x( 'Less Than 10', 'Active plugin installations' ); } else { diff --git a/src/wp-admin/includes/plugin-install.php b/src/wp-admin/includes/plugin-install.php index c27998fe9e..445412d0f3 100644 --- a/src/wp-admin/includes/plugin-install.php +++ b/src/wp-admin/includes/plugin-install.php @@ -652,7 +652,11 @@ function install_plugin_information() {
  • active_installs >= 1000000 ) { - _ex( '1+ Million', 'Active plugin installations' ); + $active_installs_millions = floor( $api->active_installs / 1000000 ); + printf( + _nx( '%s+ Million', '%s+ Million', 'Active plugin installations', $active_installs_millions ), + number_format_i18n( $active_installs_millions ) + ); } elseif ( 0 == $api->active_installs ) { _ex( 'Less Than 10', 'Active plugin installations' ); } else {