From 36e890071e9829b58a01fd064006077b1218a7ee Mon Sep 17 00:00:00 2001 From: Jb Audras Date: Mon, 17 Jul 2023 22:01:08 +0000 Subject: [PATCH] External Libraries: Update deprecated jQuery code in Farbtastic lib. This changeset updates some deprecated jQuery code in the Farbtastic external library. As this vendor script is not maintained anymore, this changeset also adds a docblock to specify that the library has been "adopted" by WP Core. Props Malae, sabernhardt, SergeyBiryukov, Presskopp, mrinal013, peterwilsoncc, oglekler, jorbin. Fixes #57946. git-svn-id: https://develop.svn.wordpress.org/trunk@56252 602fd350-edb4-49c9-b593-d223f7449a82 --- src/js/_enqueues/vendor/farbtastic.js | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/js/_enqueues/vendor/farbtastic.js b/src/js/_enqueues/vendor/farbtastic.js index 5404fb6e3d..b445081a20 100644 --- a/src/js/_enqueues/vendor/farbtastic.js +++ b/src/js/_enqueues/vendor/farbtastic.js @@ -1,9 +1,15 @@ /*! * Farbtastic: jQuery color picker plug-in v1.3u + * https://github.com/mattfarina/farbtastic * * Licensed under the GPL license: * http://www.gnu.org/licenses/gpl.html */ +/** + * Modified for WordPress: replaced deprecated jQuery methods. + * See https://core.trac.wordpress.org/ticket/57946. + */ + (function($) { $.fn.farbtastic = function (options) { @@ -49,7 +55,7 @@ $._farbtastic = function (container, callback) { fb.linkTo = function (callback) { // Unbind previous nodes if (typeof fb.callback == 'object') { - $(fb.callback).unbind('keyup', fb.updateValue); + $(fb.callback).off('keyup', fb.updateValue); } // Reset color @@ -61,7 +67,7 @@ $._farbtastic = function (container, callback) { } else if (typeof callback == 'object' || typeof callback == 'string') { fb.callback = $(callback); - fb.callback.bind('keyup', fb.updateValue); + fb.callback.on('keyup', fb.updateValue); if (fb.callback.get(0).value) { fb.setColor(fb.callback.get(0).value); } @@ -116,7 +122,7 @@ $._farbtastic = function (container, callback) { fb.mousedown = function (event) { // Capture mouse if (!document.dragging) { - $(document).bind('mousemove', fb.mousemove).bind('mouseup', fb.mouseup); + $(document).on('mousemove', fb.mousemove).on('mouseup', fb.mouseup); document.dragging = true; } @@ -155,8 +161,8 @@ $._farbtastic = function (container, callback) { */ fb.mouseup = function () { // Uncapture mouse - $(document).unbind('mousemove', fb.mousemove); - $(document).unbind('mouseup', fb.mouseup); + $(document).off('mousemove', fb.mousemove); + $(document).off('mouseup', fb.mouseup); document.dragging = false; }; @@ -262,7 +268,7 @@ $._farbtastic = function (container, callback) { }; // Install mousedown handler (the others are set on the document on-demand) - $('*', e).mousedown(fb.mousedown); + $('*', e).on('mousedown', fb.mousedown); // Init color fb.setColor('#000000');