vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-12 04:40:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Sitemaps: Correctly enforce maximum number of sitemaps in index.

Browse Source 
Before this change, the limit of 50k entries was enforced for the number of providers, not the amount of sitemaps all providers add to the index in total.

Props pbiron, swissspidy.
Fixes #50666.

git-svn-id: https://develop.svn.wordpress.org/trunk@48532 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Pascal Birchler
2020-07-21 13:55:45 +00:00
parent fd9f7232e5
commit 38cade3b07
5 changed files with 98 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/sitemaps/sitemaps-index.php
+23
View File
@@ -20,6 +20,29 @@ class Test_WP_Sitemaps_Index extends WP_UnitTestCase {
$this->assertCount( 24, $sitemap_index->get_sitemap_list() );
}
/**
* Test that a sitemap index won't contain more than 50000 sitemaps.
*
* @ticket 50666
*/
public function test_get_sitemap_list_limit() {
$registry = new WP_Sitemaps_Registry();
// add 3 providers, which combined produce more than the maximum 50000 sitemaps in the index.
$registry->add_sitemap( 'provider_1', new WP_Sitemaps_Large_Test_Provider( 25000 ) );
$registry->add_sitemap( 'provider_2', new WP_Sitemaps_Large_Test_Provider( 25000 ) );
$registry->add_sitemap( 'provider_3', new WP_Sitemaps_Large_Test_Provider( 25000 ) );
$count = 0;
foreach ( $registry->get_sitemaps() as $provider ) {
$count += count( $provider->get_url_list( 1 ) );
}
$this->assertGreaterThan( 50000, $count );
$sitemap_index = new WP_Sitemaps_Index( $registry );
$this->assertCount( 50000, $sitemap_index->get_sitemap_list() );
}
public function test_get_sitemap_list_no_entries() {
$registry = new WP_Sitemaps_Registry();