vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-03-31 18:54:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

General: Ensure consistent type for integer properties of a bookmark object.

Browse Source 
Previously, these properties could be unexpectedly converted to strings in some contexts.

This applies to the following function:

* `sanitize_bookmark_field()`

and the following properties:

* `$bookmark::link_id`
* `$bookmark::link_rating`

Follow-up to [50935].

See #53235.

git-svn-id: https://develop.svn.wordpress.org/trunk@50936 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2021-05-20 00:03:04 +00:00
parent 110f132f7e
commit 3da0ccdc95
2 changed files with 26 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/phpunit/tests/bookmark/getBookmark.php
View File

@@ -340,6 +340,20 @@ class Tests_Bookmark_GetBookmark extends WP_UnitTestCase {
);
}
/**
* @ticket 53235
*/
public function test_numeric_properties_should_be_cast_to_ints() {
$contexts = array( 'raw', 'edit', 'db', 'display', 'attribute', 'js' );
foreach ( $contexts as $context ) {
$bookmark = get_bookmark( self::$bookmark->link_id, OBJECT, $context );
$this->assertInternalType( 'int', $bookmark->link_id );
$this->assertInternalType( 'int', $bookmark->link_rating );
}
}
/**
* Initialize the get_bookmark's function arguments to match the order of the function's signature and
* reduce code in the tests.