From 3eb767b5c30292a124f067a3e160abe0842492aa Mon Sep 17 00:00:00 2001 From: Joe McGill Date: Thu, 6 Jul 2017 00:40:59 +0000 Subject: [PATCH] Sanity check $uploaderToggler in wp.media.view.UploaderInline. This ensures `$uploaderToggler` exists before checking length so any views extending or scripts accessing this view, won't encounter errors that stop execution. Props Blackbam, yahil. Fixes #41231. git-svn-id: https://develop.svn.wordpress.org/trunk@41009 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/js/media-views.js | 4 ++-- src/wp-includes/js/media/views/uploader/inline.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wp-includes/js/media-views.js b/src/wp-includes/js/media-views.js index 7ea9ed3cb6..29b56c66a8 100644 --- a/src/wp-includes/js/media-views.js +++ b/src/wp-includes/js/media-views.js @@ -8228,13 +8228,13 @@ UploaderInline = View.extend({ }, show: function() { this.$el.removeClass( 'hidden' ); - if ( this.controller.$uploaderToggler.length ) { + if ( this.controller.$uploaderToggler && this.controller.$uploaderToggler.length ) { this.controller.$uploaderToggler.attr( 'aria-expanded', 'true' ); } }, hide: function() { this.$el.addClass( 'hidden' ); - if ( this.controller.$uploaderToggler.length ) { + if ( this.controller.$uploaderToggler && this.controller.$uploaderToggler.length ) { this.controller.$uploaderToggler .attr( 'aria-expanded', 'false' ) // Move focus back to the toggle button when closing the uploader. diff --git a/src/wp-includes/js/media/views/uploader/inline.js b/src/wp-includes/js/media/views/uploader/inline.js index f6be006b6b..dfb208f851 100644 --- a/src/wp-includes/js/media/views/uploader/inline.js +++ b/src/wp-includes/js/media/views/uploader/inline.js @@ -119,13 +119,13 @@ UploaderInline = View.extend({ }, show: function() { this.$el.removeClass( 'hidden' ); - if ( this.controller.$uploaderToggler.length ) { + if ( this.controller.$uploaderToggler && this.controller.$uploaderToggler.length ) { this.controller.$uploaderToggler.attr( 'aria-expanded', 'true' ); } }, hide: function() { this.$el.addClass( 'hidden' ); - if ( this.controller.$uploaderToggler.length ) { + if ( this.controller.$uploaderToggler && this.controller.$uploaderToggler.length ) { this.controller.$uploaderToggler .attr( 'aria-expanded', 'false' ) // Move focus back to the toggle button when closing the uploader.