General: wp_safe_redirect() and wp_redirect() shouldn't allow non-3xx status codes

Redirects should use redirect status codes and if you attempt to call wp_safe_redirect or wp_redirect with a non redirect status it can lead to undesired behavior and head scratching.

Fixes #44317.
Props spenserhale, johnbillion, mjnewman for initial patch.



git-svn-id: https://develop.svn.wordpress.org/trunk@46641 602fd350-edb4-49c9-b593-d223f7449a82

tests/phpunit/tests/pluggable.php

@@ -5,6 +5,53 @@
  */
 class Tests_Pluggable extends WP_UnitTestCase {
 
+	/**
+	 * @dataProvider get_good_status_codes
+	 *
+	 * @ticket 44317
+	 * @param string $location The path or URL to redirect to.
+	 * @param int $status HTTP response status code to use.
+	 */
+	public function test_wp_redirect_good_status_code( $location, $status ) {
+		$this->assertTrue( wp_redirect( $location, $status ) );
+	}
+
+	public function get_good_status_codes() {
+		return [
+			// Expected Statuses
+			[ '/wp-admin', 301 ],
+			[ '/wp-admin', 302 ],
+			[ '/wp-admin', 307 ],
+			// Outliers that are valid
+			[ '/wp-admin', 300 ],
+			[ '/wp-admin', 399 ],
+		];
+	}
+
+	/**
+	 * @expectedException WPDieException
+	 * @dataProvider get_bad_status_codes
+	 *
+	 * @ticket 44317
+	 * @param string $location The path or URL to redirect to.
+	 * @param int $status HTTP response status code to use.
+	 */
+	public function test_wp_redirect_bad_status_code( $location, $status ) {
+		wp_redirect( $location, $status );
+	}
+
+	public function get_bad_status_codes() {
+		return [
+			// Tests for bad arguments
+			[ '/wp-admin', 404 ],
+			[ '/wp-admin', 410 ],
+			[ '/wp-admin', 500 ],
+			// Tests for condition.
+			[ '/wp-admin', 299 ],
+			[ '/wp-admin', 400 ],
+		];
+	}
+
 	/**
 	 * Tests that the signatures of all functions in pluggable.php match their expected signature.
 	 *