vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-28 21:10:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Browse Source 
Adds a `public` visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a `private` visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a `_` prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

git-svn-id: https://develop.svn.wordpress.org/trunk@52010 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Tonya Mork
2021-11-04 15:22:47 +00:00
parent 80380cd374
commit 40ac5de838
327 changed files with 3656 additions and 3969 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
tests/phpunit/tests/customize/setting.php
View File

@@ -17,7 +17,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
*/
public $undefined;
function set_up() {
public function set_up() {
parent::set_up();
require_once ABSPATH . WPINC . '/class-wp-customize-manager.php';
$GLOBALS['wp_customize'] = new WP_Customize_Manager();
@@ -25,13 +25,13 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
$this->undefined = new stdClass();
}
function tear_down() {
public function tear_down() {
$this->manager = null;
unset( $GLOBALS['wp_customize'] );
parent::tear_down();
}
function test_constructor_without_args() {
public function test_constructor_without_args() {
$setting = new WP_Customize_Setting( $this->manager, 'foo' );
$this->assertSame( $this->manager, $setting->manager );
$this->assertSame( 'foo', $setting->id );
@@ -84,11 +84,11 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
* @param mixed $value The setting value.
* @param WP_Customize_Setting $setting The setting object.
*/
function sanitize_js_callback_base64_for_testing( $value, $setting ) {
public function sanitize_js_callback_base64_for_testing( $value, $setting ) {
return base64_encode( $value );
}
function test_constructor_with_args() {
public function test_constructor_with_args() {
$args = array(
'type' => 'option',
'capability' => 'edit_posts',
@@ -136,7 +136,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
*
* @see WP_Customize_Setting::value()
*/
function test_preview_standard_types_non_multidimensional() {
public function test_preview_standard_types_non_multidimensional() {
wp_set_current_user( $this->factory()->user->create( array( 'role' => 'administrator' ) ) );
$_POST['customized'] = wp_slash( wp_json_encode( $this->post_data_overrides ) );
@@ -215,7 +215,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
* @see WP_Customize_Setting::preview()
* @see WP_Customize_Setting::value()
*/
function test_preview_standard_types_multidimensional() {
public function test_preview_standard_types_multidimensional() {
wp_set_current_user( $this->factory()->user->create( array( 'role' => 'administrator' ) ) );
$_POST['customized'] = wp_slash( wp_json_encode( $this->post_data_overrides ) );
@@ -316,7 +316,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
*/
protected $custom_type_data_previewed;
function custom_type_getter( $name, $default = null ) {
private function custom_type_getter( $name, $default = null ) {
if ( did_action( "customize_preview_{$name}" ) && array_key_exists( $name, $this->custom_type_data_previewed ) ) {
$value = $this->custom_type_data_previewed[ $name ];
} elseif ( array_key_exists( $name, $this->custom_type_data_saved ) ) {
@@ -327,7 +327,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
return $value;
}
function custom_type_setter( $name, $value ) {
private function custom_type_setter( $name, $value ) {
$this->custom_type_data_saved[ $name ] = $value;
}
@@ -339,7 +339,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
*
* @return mixed|null
*/
function custom_type_value_filter( $default, $setting = null ) {
public function custom_type_value_filter( $default, $setting = null ) {
$name = preg_replace( '/^customize_value_/', '', current_filter() );
$this->assertInstanceOf( 'WP_Customize_Setting', $setting );
$id_data = $setting->id_data();
@@ -350,7 +350,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
/**
* @param WP_Customize_Setting $setting
*/
function custom_type_preview( $setting ) {
public function custom_type_preview( $setting ) {
$previewed_value = $setting->post_value( $this->undefined );
if ( $this->undefined !== $previewed_value ) {
$this->custom_type_data_previewed[ $setting->id ] = $previewed_value;
@@ -361,7 +361,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
*
* @see WP_Customize_Setting::preview()
*/
function test_preview_custom_type() {
public function test_preview_custom_type() {
wp_set_current_user( $this->factory()->user->create( array( 'role' => 'administrator' ) ) );
$type = 'custom_type';
$post_data_overrides = array(
@@ -473,7 +473,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
*
* @ticket 30988
*/
function test_non_posted_setting_applying_default_value_in_preview() {
public function test_non_posted_setting_applying_default_value_in_preview() {
$type = 'option';
$name = 'unset_option_without_post_value';
$default = "default_value_{$name}";
@@ -491,7 +491,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
* @see WP_Customize_Setting::save()
* @see WP_Customize_Setting::update()
*/
function test_update_custom_type() {
public function test_update_custom_type() {
$type = 'custom';
$name = 'foo';
$setting = new WP_Customize_Setting( $this->manager, $name, compact( 'type' ) );
@@ -526,7 +526,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
* @param mixed $value
* @param WP_Customize_Setting $setting
*/
function handle_customize_update_custom_foo_action( $value, $setting = null ) {
public function handle_customize_update_custom_foo_action( $value, $setting = null ) {
$this->assertSame( 'hello world \\o/', $value );
$this->assertInstanceOf( 'WP_Customize_Setting', $setting );
}
@@ -537,7 +537,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
* @see Tests_WP_Customize_Setting::test_update_custom_type()
* @param WP_Customize_Setting $setting
*/
function handle_customize_save_custom_foo_action( $setting ) {
public function handle_customize_save_custom_foo_action( $setting ) {
$this->assertInstanceOf( 'WP_Customize_Setting', $setting );
$this->assertSame( 'custom', $setting->type );
$this->assertSame( 'foo', $setting->id );
@@ -550,7 +550,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
*
* @ticket 31428
*/
function test_is_current_blog_previewed() {
public function test_is_current_blog_previewed() {
wp_set_current_user( $this->factory()->user->create( array( 'role' => 'administrator' ) ) );
$type = 'option';
$name = 'blogname';
@@ -572,7 +572,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
* @group multisite
* @group ms-required
*/
function test_previewing_with_switch_to_blog() {
public function test_previewing_with_switch_to_blog() {
wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
$type = 'option';
$name = 'blogdescription';
@@ -594,7 +594,7 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
/**
* @ticket 33499
*/
function test_option_autoloading() {
public function test_option_autoloading() {
global $wpdb;
wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );