vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-01 07:40:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Browse Source 
Adds a `public` visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a `private` visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a `_` prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

git-svn-id: https://develop.svn.wordpress.org/trunk@52010 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Tonya Mork
2021-11-04 15:22:47 +00:00
parent 80380cd374
commit 40ac5de838
327 changed files with 3656 additions and 3969 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
tests/phpunit/tests/file.php
View File

@@ -5,7 +5,7 @@
*/
class Tests_File extends WP_UnitTestCase {
function set_up() {
public function set_up() {
parent::set_up();
$this->dir = untrailingslashit( get_temp_dir() );
@@ -17,7 +17,7 @@ class Tests_File extends WP_UnitTestCase {
* @group plugins
* @group themes
*/
function test_get_file_data() {
public function test_get_file_data() {
$theme_headers = array(
'Name' => 'Theme Name',
'ThemeURI' => 'Theme URI',
@@ -48,7 +48,7 @@ class Tests_File extends WP_UnitTestCase {
* @group plugins
* @group themes
*/
function test_get_file_data_with_cr_line_endings() {
public function test_get_file_data_with_cr_line_endings() {
$headers = array(
'SomeHeader' => 'Some Header',
'Description' => 'Description',
@@ -72,7 +72,7 @@ class Tests_File extends WP_UnitTestCase {
* @group plugins
* @group themes
*/
function test_get_file_data_with_php_open_tag_prefix() {
public function test_get_file_data_with_php_open_tag_prefix() {
$headers = array(
'TemplateName' => 'Template Name',
);
@@ -87,7 +87,7 @@ class Tests_File extends WP_UnitTestCase {
}
}
function is_unique_writable_file( $path, $filename ) {
private function is_unique_writable_file( $path, $filename ) {
$fullpath = $path . DIRECTORY_SEPARATOR . $filename;
$fp = fopen( $fullpath, 'x' );
@@ -110,7 +110,7 @@ class Tests_File extends WP_UnitTestCase {
return $result;
}
function test_unique_filename_is_valid() {
public function test_unique_filename_is_valid() {
// Make sure it produces a valid, writable, unique filename.
$filename = wp_unique_filename( $this->dir, __FUNCTION__ . '.txt' );
@@ -119,7 +119,7 @@ class Tests_File extends WP_UnitTestCase {
unlink( $this->dir . DIRECTORY_SEPARATOR . $filename );
}
function test_unique_filename_is_unique() {
public function test_unique_filename_is_unique() {
// Make sure it produces two unique filenames.
$name = __FUNCTION__;
@@ -135,7 +135,7 @@ class Tests_File extends WP_UnitTestCase {
unlink( $this->dir . DIRECTORY_SEPARATOR . $filename2 );
}
function test_unique_filename_is_sanitized() {
public function test_unique_filename_is_sanitized() {
$name = __FUNCTION__;
$filename = wp_unique_filename( $this->dir, $name . $this->badchars . '.txt' );
@@ -147,7 +147,7 @@ class Tests_File extends WP_UnitTestCase {
unlink( $this->dir . DIRECTORY_SEPARATOR . $filename );
}
function test_unique_filename_with_slashes() {
public function test_unique_filename_with_slashes() {
$name = __FUNCTION__;
// "foo/foo.txt"
$filename = wp_unique_filename( $this->dir, $name . '/' . $name . '.txt' );
@@ -160,7 +160,7 @@ class Tests_File extends WP_UnitTestCase {
unlink( $this->dir . DIRECTORY_SEPARATOR . $filename );
}
function test_unique_filename_multiple_ext() {
public function test_unique_filename_multiple_ext() {
$name = __FUNCTION__;
$filename = wp_unique_filename( $this->dir, $name . '.php.txt' );
@@ -172,7 +172,7 @@ class Tests_File extends WP_UnitTestCase {
unlink( $this->dir . DIRECTORY_SEPARATOR . $filename );
}
function test_unique_filename_no_ext() {
public function test_unique_filename_no_ext() {
$name = __FUNCTION__;
$filename = wp_unique_filename( $this->dir, $name );
@@ -186,13 +186,13 @@ class Tests_File extends WP_UnitTestCase {
/**
* @dataProvider data_wp_tempnam_filenames
*/
function test_wp_tempnam( $case ) {
public function test_wp_tempnam( $case ) {
$file = wp_tempnam( $case );
unlink( $file );
$this->assertNotEmpty( basename( basename( $file, '.tmp' ), '.zip' ) );
}
function data_wp_tempnam_filenames() {
public function data_wp_tempnam_filenames() {
return array(
array( '0.zip' ),
array( '0.1.2.3.zip' ),
@@ -206,7 +206,7 @@ class Tests_File extends WP_UnitTestCase {
/**
* @ticket 47186
*/
function test_file_signature_functions_as_expected() {
public function test_file_signature_functions_as_expected() {
$file = wp_tempnam();
file_put_contents( $file, 'WordPress' );
@@ -239,7 +239,7 @@ class Tests_File extends WP_UnitTestCase {
/**
* @ticket 47186
*/
function test_file_signature_expected_failure() {
public function test_file_signature_expected_failure() {
$file = wp_tempnam();
file_put_contents( $file, 'WordPress' );
@@ -256,7 +256,7 @@ class Tests_File extends WP_UnitTestCase {
$this->assertSame( 'signature_verification_failed', $verify->get_error_code() );
}
function filter_trust_plus85Tq_key( $keys ) {
public function filter_trust_plus85Tq_key( $keys ) {
// A static once-off key used to verify verify_file_signature() works as expected.
$keys[] = '+85TqMhxQVAYVW4BSCVkJQvZH4q7z8I9lePbvngvf7A=';