vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-11 20:30:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Browse Source 
Adds a `public` visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a `private` visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a `_` prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

git-svn-id: https://develop.svn.wordpress.org/trunk@52010 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Tonya Mork
2021-11-04 15:22:47 +00:00
parent 80380cd374
commit 40ac5de838
327 changed files with 3656 additions and 3969 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/load/wpConvertHrToBytes.php
+2 -2
View File
@@ -17,7 +17,7 @@ class Tests_Load_wpConvertHrToBytes extends WP_UnitTestCase {
* @param int|string $value The value passed to wp_convert_hr_to_bytes().
* @param int $expected The expected output of wp_convert_hr_to_bytes().
*/
function test_wp_convert_hr_to_bytes( $value, $expected ) {
public function test_wp_convert_hr_to_bytes( $value, $expected ) {
$this->assertSame( $expected, wp_convert_hr_to_bytes( $value ) );
}
@@ -31,7 +31,7 @@ class Tests_Load_wpConvertHrToBytes extends WP_UnitTestCase {
* }
* }
*/
function data_wp_convert_hr_to_bytes() {
public function data_wp_convert_hr_to_bytes() {
$array = array(
// Integer input.
array( -1, -1 ), // = no memory limit.
tests/phpunit/tests/load/wpIsIniValueChangeable.php
+2 -2
View File
@@ -18,7 +18,7 @@ class Tests_Load_wpIsIniValueChangeable extends WP_UnitTestCase {
* @param string $setting The setting passed to wp_is_ini_value_changeable().
* @param bool $expected The expected output of wp_convert_hr_to_bytes().
*/
function test_wp_is_ini_value_changeable( $setting, $expected ) {
public function test_wp_is_ini_value_changeable( $setting, $expected ) {
$this->assertSame( $expected, wp_is_ini_value_changeable( $setting ) );
}
@@ -32,7 +32,7 @@ class Tests_Load_wpIsIniValueChangeable extends WP_UnitTestCase {
* }
* }
*/
function data_wp_is_ini_value_changeable() {
public function data_wp_is_ini_value_changeable() {
$array = array(
array( 'memory_limit', true ), // PHP_INI_ALL.
array( 'log_errors', true ), // PHP_INI_ALL.