vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-04 20:54:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use only LEFT JOINs when a meta_query contains a NOT EXISTS clause.

Browse Source 
Mixing LEFT and INNER JOIN in these cases results in posts with no metadata
being improperly excluded from results.

Props johnrom.
Fixes #29062.

git-svn-id: https://develop.svn.wordpress.org/trunk@29890 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2014-10-14 02:16:28 +00:00
parent e7d3a9a26c
commit 40dc982a30
2 changed files with 44 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/wp-includes/meta.php
View File

@@ -1123,6 +1123,14 @@ class WP_Meta_Query {
$sql = $this->get_sql_clauses();
/*
* If any JOINs are LEFT JOINs (as in the case of NOT EXISTS), then all JOINs should
* be LEFT. Otherwise posts with no metadata will be excluded from results.
*/
if ( false !== strpos( $sql['join'], 'LEFT JOIN' ) ) {
$sql['join'] = str_replace( 'INNER JOIN', 'LEFT JOIN', $sql['join'] );
}
/**
* Filter the meta query's generated SQL.
*