vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 22:30:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

More careful type conversion in WP_Query is_*() methods.

Browse Source 
`is_array( 1, '1-foo' )` returns true, which means that `is_page( 1 )`
was returning true when on a page with the slug '1-foo'. We avoid this odd
behavior by casting the queried object ID to a string before testing against
the value passed to the conditional function.

This also helps to avoid a problem where an arbitrary value for `$page` would
cause `is_page( $page )` to return true if the query had been manipulated by
a plugin to show that the current page's ID is 0.

Props boonebgorges, r-a-y, nunomorgadinho, wonderboymusic, clifgriffin.
Fixes #24674.

git-svn-id: https://develop.svn.wordpress.org/trunk@31458 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2015-02-14 02:08:46 +00:00
parent 78b02ec722
commit 4138275df9
2 changed files with 156 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/wp-includes/query.php
View File

@@ -4077,7 +4077,7 @@ class WP_Query {
$post_obj = $this->get_queried_object();
if ( in_array( $post_obj->ID, $attachment ) ) {
if ( in_array( (string) $post_obj->ID, $attachment ) ) {
return true;
} elseif ( in_array( $post_obj->post_title, $attachment ) ) {
return true;
@@ -4109,7 +4109,7 @@ class WP_Query {
$author = (array) $author;
if ( in_array( $author_obj->ID, $author ) )
if ( in_array( (string) $author_obj->ID, $author ) )
return true;
elseif ( in_array( $author_obj->nickname, $author ) )
return true;
@@ -4141,7 +4141,7 @@ class WP_Query {
$category = (array) $category;
if ( in_array( $cat_obj->term_id, $category ) )
if ( in_array( (string) $cat_obj->term_id, $category ) )
return true;
elseif ( in_array( $cat_obj->name, $category ) )
return true;
@@ -4173,7 +4173,7 @@ class WP_Query {
$tag = (array) $tag;
if ( in_array( $tag_obj->term_id, $tag ) )
if ( in_array( (string) $tag_obj->term_id, $tag ) )
return true;
elseif ( in_array( $tag_obj->name, $tag ) )
return true;
@@ -4370,7 +4370,7 @@ class WP_Query {
$page = (array) $page;
if ( in_array( $page_obj->ID, $page ) ) {
if ( in_array( (string) $page_obj->ID, $page ) ) {
return true;
} elseif ( in_array( $page_obj->post_title, $page ) ) {
return true;
@@ -4463,7 +4463,7 @@ class WP_Query {
$post = (array) $post;
if ( in_array( $post_obj->ID, $post ) ) {
if ( in_array( (string) $post_obj->ID, $post ) ) {
return true;
} elseif ( in_array( $post_obj->post_title, $post ) ) {
return true;