From 42d6b5dd1e9fdcff752640c202aa2696dfd24956 Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Tue, 13 May 2014 04:43:22 +0000 Subject: [PATCH] Eliminate use of `extract()` in `trackback_url_list()`. See #22400. git-svn-id: https://develop.svn.wordpress.org/trunk@28382 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/post.php | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/wp-includes/post.php b/src/wp-includes/post.php index 85d0d16baf..87ca75057f 100644 --- a/src/wp-includes/post.php +++ b/src/wp-includes/post.php @@ -3820,25 +3820,22 @@ function get_to_ping($post_id) { * @param string $tb_list Comma separated list of URLs * @param int $post_id Post ID */ -function trackback_url_list($tb_list, $post_id) { +function trackback_url_list( $tb_list, $post_id ) { if ( ! empty( $tb_list ) ) { // get post data - $postdata = get_post($post_id, ARRAY_A); - - // import postdata as variables - extract($postdata, EXTR_SKIP); + $postdata = get_post( $post_id, ARRAY_A ); // form an excerpt - $excerpt = strip_tags($post_excerpt ? $post_excerpt : $post_content); + $excerpt = strip_tags( $postdata['post_excerpt'] ? $postdata['post_excerpt'] : $postdata['post_content'] ); - if (strlen($excerpt) > 255) { - $excerpt = substr($excerpt,0,252) . '…'; + if ( strlen( $excerpt ) > 255 ) { + $excerpt = substr( $excerpt, 0, 252 ) . '…'; } - $trackback_urls = explode(',', $tb_list); - foreach( (array) $trackback_urls as $tb_url) { - $tb_url = trim($tb_url); - trackback($tb_url, wp_unslash($post_title), $excerpt, $post_id); + $trackback_urls = explode( ',', $tb_list ); + foreach( (array) $trackback_urls as $tb_url ) { + $tb_url = trim( $tb_url ); + trackback( $tb_url, wp_unslash( $postdata['post_title'] ), $excerpt, $post_id ); } } }