From 43c8ec5f3229bf72ddbecd1285c28ec16f251576 Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Thu, 3 Sep 2015 23:22:32 +0000 Subject: [PATCH] Handle more cases (`untrailingslashit`, HTTPS urls) for sanitizing an author URL for display in the comments list table. Props afercia, mehulkaklotar, swissspidy, johnbillion. Fixes #33291. git-svn-id: https://develop.svn.wordpress.org/trunk@33894 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/class-wp-comments-list-table.php | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/wp-admin/includes/class-wp-comments-list-table.php b/src/wp-admin/includes/class-wp-comments-list-table.php index 0d2d16eb8a..a2120a9e64 100644 --- a/src/wp-admin/includes/class-wp-comments-list-table.php +++ b/src/wp-admin/includes/class-wp-comments-list-table.php @@ -636,19 +636,15 @@ class WP_Comments_List_Table extends WP_List_Table { global $comment_status; $author_url = get_comment_author_url( $comment->comment_ID ); - if ( 'http://' == $author_url ) { - $author_url = ''; - } - $author_url_display = preg_replace( '|http://(www\.)?|i', '', $author_url ); + $author_url_display = untrailingslashit( preg_replace( '|^http(s)?://(www\.)?|i', '', $author_url ) ); if ( strlen( $author_url_display ) > 50 ) { $author_url_display = wp_html_excerpt( $author_url_display, 49, '…' ); } - echo ""; comment_author( $comment->comment_ID ); echo '
'; - if ( !empty( $author_url ) ) { - echo "$author_url_display
"; + if ( ! empty( $author_url_display ) ) { + printf( '%s
', esc_url( $author_url ), esc_html( $author_url_display ) ); } if ( $this->user_can ) {