vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-10-04 06:37:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Users: Ensure that users with no role on a site are taken into consideration when listing users on Multisite.

Browse Source 
This ensures that users who are a member of a site but have no role are correctly listed on the Users screen and can be filtered from the 'None' role filter.

Props tobi823, flixos90, scottlee

Fixes #36196


git-svn-id: https://develop.svn.wordpress.org/trunk@41138 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
John Blackbourn
2017-07-25 00:23:44 +00:00
parent 06160eb060
commit 44491ba49f
4 changed files with 33 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wp-admin/includes/class-wp-users-list-table.php
+2 -5
View File
@@ -98,7 +98,7 @@ class WP_Users_List_Table extends WP_List_Table {
$args = array(
'number' => $users_per_page,
'offset' => ( $paged-1 ) * $users_per_page,
'include' => wp_get_users_with_no_role(),
'include' => wp_get_users_with_no_role( $this->site_id ),
'search' => $usersearch,
'fields' => 'all_with_meta'
);
@@ -177,7 +177,7 @@ class WP_Users_List_Table extends WP_List_Table {
if ( $this->is_site_users ) {
$url = 'site-users.php?id=' . $this->site_id;
switch_to_blog( $this->site_id );
$users_of_blog = count_users();
$users_of_blog = count_users( 'time', $this->site_id );
restore_current_blog();
} else {
$url = 'users.php';
@@ -369,9 +369,6 @@ class WP_Users_List_Table extends WP_List_Table {
$post_counts = count_many_users_posts( array_keys( $this->items ) );
foreach ( $this->items as $userid => $user_object ) {
if ( is_multisite() && empty( $user_object->allcaps ) )
continue;
echo "\n\t" . $this->single_row( $user_object, '', '', isset( $post_counts ) ? $post_counts[ $userid ] : 0 );
}
}