vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-10-06 23:58:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

When calling unset(), it is unnecessary to immediately precede it with a call to isset().

Browse Source 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32545 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-05-22 05:46:47 +00:00
parent 06ea5c78be
commit 46752a491e
9 changed files with 17 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wp-admin/includes/media.php
+2 -4
View File
@@ -355,8 +355,7 @@ function media_handle_upload($file_id, $post_id, $post_data = array(), $override
), $post_data );
// This should never be set as it would then overwrite an existing attachment.
if ( isset( $attachment['ID'] ) )
unset( $attachment['ID'] );
unset( $attachment['ID'] );
// Save the data
$id = wp_insert_attachment($attachment, $file, $post_id);
@@ -419,8 +418,7 @@ function media_handle_sideload($file_array, $post_id, $desc = null, $post_data =
), $post_data );
// This should never be set as it would then overwrite an existing attachment.
if ( isset( $attachment['ID'] ) )
unset( $attachment['ID'] );
unset( $attachment['ID'] );
// Save the attachment metadata
$id = wp_insert_attachment($attachment, $file, $post_id);