vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-01 15:50:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Administration: Convert H5 usage in Screen Options to use fieldsets and legends.

Browse Source 
These H5 (heading level 5) don't allow for a good headings hierarchy and shouldn't be headings in the first place. Each group of options has now its own fieldset and legend.
In `render_screen_options()`, introduce two new "render" methods: `render_meta_boxes_preferences()` and `render_list_table_columns_preferences()` for consistency with already existing render methods and cleaner code.

Props joedolson, afercia.
Fixes #33646.

git-svn-id: https://develop.svn.wordpress.org/trunk@34991 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Andrea Fercia
2015-10-09 18:04:18 +00:00
parent bb31c1ada8
commit 4b5f84295a
3 changed files with 130 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/wp-admin/css/common.css
View File

@@ -1570,10 +1570,17 @@ form.upgrade .hint {
background-position: bottom left;
}
#screen-options-wrap h5,
#screen-options-wrap h5, /* Back-compat for old plugins */
#screen-options-wrap legend,
#contextual-help-wrap h5 {
margin: 8px 0;
font-size: 13px;
margin: 0;
padding: 8px 0;
font-size: 13px;
font-weight: 600;
}
.ie8 #screen-options-wrap legend {
color: inherit;
}
.metabox-prefs label {
@@ -1582,27 +1589,30 @@ form.upgrade .hint {
line-height: 30px;
}
.metabox-prefs label input[type=checkbox] {
margin-top: -4px;
#number-of-columns {
display: inline-block;
vertical-align: middle;
line-height: 30px;
}
.metabox-prefs input[type=checkbox] {
margin-top: 0;
margin-right: 6px;
}
.metabox-prefs label input {
margin: 0 5px 0 2px;
.metabox-prefs label input,
.metabox-prefs label input[type=checkbox] {
margin: -4px 5px 0 0;
}
.metabox-prefs .columns-prefs label input {
margin: 0 2px;
margin: -1px 2px 0 0;
}
.metabox-prefs label a {
display: none;
}
.metabox-prefs .screen-options {
padding-top: 10px;
}
.metabox-prefs .screen-options input,
.metabox-prefs .screen-options label {
margin-top: 0;
@@ -1619,6 +1629,10 @@ form.upgrade .hint {
padding-right: 0;
}
.screen-options + .screen-options {
margin-top: 10px;
}
/*------------------------------------------------------------------------------
6.2 - Help Menu
------------------------------------------------------------------------------*/
@@ -1900,7 +1914,7 @@ html.wp-toolbar {
}
.columns-prefs label {
padding: 0 5px;
padding: 0 10px 0 0;
}
/* @todo: what is this doing here */

2
src/wp-admin/css/customize-nav-menus.css
View File

@@ -349,7 +349,7 @@
display: none;
background: #fff;
border-top: 1px solid #ddd;
padding: 4px 15px 0;
padding: 4px 15px 15px;
}
.wp-customizer .metabox-prefs label {