vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-11 12:20:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Support array values in WP_Date_Query::validate_date_values().

Browse Source 
Introduced in [29925], `validate_date_values()` throws `_doing_it_wrong()`
notices when values passed as part of a `WP_Date_Query` do not reflect actual
dates. However, the validation did not account properly for the case where an
array of multiple values is passed, as when doing IN or BETWEEN queries.

Props dlh.
Fixes #31001 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31179 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2015-01-14 16:50:09 +00:00
parent 1a930c5d43
commit 4b6957c852
2 changed files with 91 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/date/query.php
+62
View File
@@ -960,6 +960,68 @@ class Tests_WP_Date_Query extends WP_UnitTestCase {
}
}
/**
* @ticket 31001
*/
public function test_validate_date_values_should_process_array_value_for_year() {
$p1 = $this->factory->post->create( array( 'post_date' => '2015-01-12' ) );
$p2 = $this->factory->post->create( array( 'post_date' => '2013-01-12' ) );
$q = new WP_Query( array(
'date_query' => array(
array(
'compare' => 'BETWEEN',
'year' => array( 2012, 2014 ),
),
),
'fields' => 'ids',
) );
$this->assertEquals( array( $p2 ), $q->posts );
}
/**
* @ticket 31001
*/
public function test_validate_date_values_should_process_array_value_for_day() {
$p1 = $this->factory->post->create( array( 'post_date' => '2015-01-12' ) );
$p2 = $this->factory->post->create( array( 'post_date' => '2015-01-10' ) );
$q = new WP_Query( array(
'date_query' => array(
array(
'compare' => 'BETWEEN',
'day' => array( 9, 11 ),
),
),
'fields' => 'ids',
) );
$this->assertEquals( array( $p2 ), $q->posts );
}
/**
* @ticket 31001
* @expectedIncorrectUsage WP_Date_Query
*/
public function test_validate_date_values_should_process_array_value_for_day_when_values_are_invalid() {
$p1 = $this->factory->post->create( array( 'post_date' => '2015-01-12' ) );
$p2 = $this->factory->post->create( array( 'post_date' => '2015-01-10' ) );
$q = new WP_Query( array(
'date_query' => array(
array(
'compare' => 'BETWEEN',
'day' => array( 9, 32 ),
),
),
'fields' => 'ids',
) );
// MySQL ignores the invalid clause.
$this->assertEquals( array( $p1, $p2 ), $q->posts );
}
/** Helpers **********************************************************/
public function date_query_valid_columns_callback( $columns ) {