vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-11 20:30:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Query: Use WP_Query in get_page_by_path.

Browse Source 
Replace raw database queries in `get_page_by_path` with a call to `WP_Query` class. This has a number of benefits, including improved caching and priming of post caches. To maintain backwards compatibility, this function calls `WP_Query` to gets all matching posts of all post statuses.  

Props spacedmonkey, peterwilsoncc, costdev, 
Fixes #56689.

git-svn-id: https://develop.svn.wordpress.org/trunk@55169 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jonny Harris
2023-01-31 16:54:22 +00:00
parent 620760e1c1
commit 4ca85e7528
2 changed files with 118 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/post/getPageByPath.php
+95
View File
@@ -103,6 +103,101 @@ class Tests_Post_GetPageByPath extends WP_UnitTestCase {
$this->assertSame( $p3, $found->ID );
}
/**
* @ticket 56689
*
* @covers ::get_page_by_path
*/
public function test_should_match_nested_page_query_count() {
$p1 = self::factory()->post->create(
array(
'post_type' => 'page',
'post_name' => 'foo',
)
);
$p2 = self::factory()->post->create(
array(
'post_type' => 'page',
'post_name' => 'bar',
'post_parent' => $p1,
)
);
$p3 = self::factory()->post->create(
array(
'post_type' => 'page',
'post_name' => 'baz',
'post_parent' => $p2,
)
);
$queries_before = get_num_queries();
$found = get_page_by_path( 'foo/bar/baz' );
$queries_after = get_num_queries();
$cached_post = wp_cache_get( $p1, 'posts' );
$this->assertSame( 1, $queries_after - $queries_before, 'Only one query should run' );
$this->assertSame( $p3, $found->ID, 'Check to see if the result is correct' );
$this->assertIsObject( $cached_post, 'The cached post is not an object' );
}
/**
* @ticket 56689
*
* @covers ::get_page_by_path
*/
public function test_should_match_nested_page_query_count_status() {
$p1 = self::factory()->post->create(
array(
'post_type' => 'page',
'post_name' => 'foo',
'post_status' => 'draft',
)
);
$p2 = self::factory()->post->create(
array(
'post_type' => 'page',
'post_name' => 'bar',
'post_parent' => $p1,
)
);
$p3 = self::factory()->post->create(
array(
'post_type' => 'page',
'post_name' => 'baz',
'post_parent' => $p2,
)
);
$queries_before = get_num_queries();
$found = get_page_by_path( 'foo/bar/baz' );
$queries_after = get_num_queries();
$cached_post = wp_cache_get( $p1, 'posts' );
$this->assertSame( 1, $queries_after - $queries_before, 'Only one query should run' );
$this->assertSame( $p3, $found->ID, 'Check to see if the result is correct' );
$this->assertIsObject( $cached_post, 'The cached post is not an object' );
}
/**
* @ticket 56689
*
* @covers ::get_page_by_path
*/
public function test_should_return_null_for_invalid_path() {
$queries_before = get_num_queries();
$get_1 = get_page_by_path( 'should/return/null/for/an/invalid/path' );
$get_2 = get_page_by_path( 'should/return/null/for/an/invalid/path' );
$queries_after = get_num_queries();
$this->assertNull( $get_1, 'Invalid path should return null.' );
$this->assertSame( 1, $queries_after - $queries_before, 'Only one query should run.' );
$this->assertSame( $get_1, $get_2, 'The cached result should be the same as the uncached result.' );
}
public function test_should_not_make_partial_match() {
$p1 = self::factory()->post->create(
array(