From 4eb545aba0157c09519fb817126f665a2f16dcf9 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Sat, 21 Sep 2019 12:48:29 +0000 Subject: [PATCH] Code Modernization: Use the `**` operator instead of the `pow()` function in `wp_convert_bytes_to_hr()` for better performance. Use the `MB_IN_BYTES` constant instead of the `pow()` function in `WP_Customize_Manager::_validate_header_video()` for better readability. Props ayeshrajans, jrf. Fixes #48083. git-svn-id: https://develop.svn.wordpress.org/trunk@46225 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/class-wp-customize-manager.php | 2 +- src/wp-includes/deprecated.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/class-wp-customize-manager.php b/src/wp-includes/class-wp-customize-manager.php index e1ca84fb15..d1cde4ae43 100644 --- a/src/wp-includes/class-wp-customize-manager.php +++ b/src/wp-includes/class-wp-customize-manager.php @@ -5926,7 +5926,7 @@ final class WP_Customize_Manager { $video = get_attached_file( absint( $value ) ); if ( $video ) { $size = filesize( $video ); - if ( 8 < $size / pow( 1024, 2 ) ) { // Check whether the size is larger than 8MB. + if ( $size > 8 * MB_IN_BYTES ) { $validity->add( 'size_too_large', __( 'This video file is too large to use as a header video. Try a shorter video or optimize the compression settings and re-upload a file that is less than 8MB. Or, upload your video to YouTube and link it with the option below.' ) diff --git a/src/wp-includes/deprecated.php b/src/wp-includes/deprecated.php index e0494d8faa..215213f70b 100644 --- a/src/wp-includes/deprecated.php +++ b/src/wp-includes/deprecated.php @@ -3346,7 +3346,7 @@ function wp_convert_bytes_to_hr( $bytes ) { $units = array( 0 => 'B', 1 => 'KB', 2 => 'MB', 3 => 'GB', 4 => 'TB' ); $log = log( $bytes, KB_IN_BYTES ); $power = (int) $log; - $size = pow( KB_IN_BYTES, $log - $power ); + $size = KB_IN_BYTES ** ( $log - $power ); if ( ! is_nan( $size ) && array_key_exists( $power, $units ) ) { $unit = $units[ $power ];