vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Add failure messages for site icon and custom logo tests.

Browse Source 
This makes the assertions more helpful, as per the [https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#using-assertions Writing PHP Tests] guidelines:
> All PHPUnit assertions, as well as all WordPress custom assertions, allow for a `$message` parameter to be passed. This message will be displayed when the assertion fails and can help immensely when debugging a test. This parameter should always be used if more than one assertion is used in a test method.

Follow-up to [33181], [36905].

See #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@53773 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2022-07-25 13:31:24 +00:00
parent c1cf07e4e3
commit 4ed912c8c3
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
tests/phpunit/tests/general/template.php
View File

@ -38,13 +38,13 @@ class Tests_General_Template extends WP_UnitTestCase {
* @requires function imagejpeg
*/
public function test_get_site_icon_url() {
$this->assertEmpty( get_site_icon_url() );
$this->assertEmpty( get_site_icon_url(), 'Site icon URL should not be set initially.' );
$this->set_site_icon();
$this->assertSame( $this->site_icon_url, get_site_icon_url() );
$this->assertSame( $this->site_icon_url, get_site_icon_url(), 'Site icon URL should be set.' );
$this->remove_site_icon();
$this->assertEmpty( get_site_icon_url() );
$this->assertEmpty( get_site_icon_url(), 'Site icon URL should not be set after removal.' );
}
/**
@ -67,13 +67,13 @@ class Tests_General_Template extends WP_UnitTestCase {
* @requires function imagejpeg
*/
public function test_has_site_icon() {
$this->assertFalse( has_site_icon() );
$this->assertFalse( has_site_icon(), 'Site icon should not be set initially.' );
$this->set_site_icon();
$this->assertTrue( has_site_icon() );
$this->assertTrue( has_site_icon(), 'Site icon should be set.' );
$this->remove_site_icon();
$this->assertFalse( has_site_icon() );
$this->assertFalse( has_site_icon(), 'Site icon should not be set after removal.' );
}
/**
@ -261,13 +261,13 @@ class Tests_General_Template extends WP_UnitTestCase {
* @since 4.5.0
*/
public function test_has_custom_logo() {
$this->assertFalse( has_custom_logo() );
$this->assertFalse( has_custom_logo(), 'Custom logo should not be set initially.' );
$this->set_custom_logo();
$this->assertTrue( has_custom_logo() );
$this->assertTrue( has_custom_logo(), 'Custom logo should be set.' );
$this->remove_custom_logo();
$this->assertFalse( has_custom_logo() );
$this->assertFalse( has_custom_logo(), 'Custom logo should not be set after removal.' );
}
/**
@ -304,15 +304,15 @@ class Tests_General_Template extends WP_UnitTestCase {
* @since 4.5.0
*/
public function test_get_custom_logo() {
$this->assertEmpty( get_custom_logo() );
$this->assertEmpty( get_custom_logo(), 'Custom logo should not be set initially.' );
$this->set_custom_logo();
$custom_logo = get_custom_logo();
$this->assertNotEmpty( $custom_logo );
$this->assertIsString( $custom_logo );
$this->assertNotEmpty( $custom_logo, 'Custom logo markup should not be empty.' );
$this->assertIsString( $custom_logo, 'Custom logo markup should be a string.' );
$this->remove_custom_logo();
$this->assertEmpty( get_custom_logo() );
$this->assertEmpty( get_custom_logo(), 'Custom logo should not be set after removal.' );
}
/**
@ -402,7 +402,7 @@ class Tests_General_Template extends WP_UnitTestCase {
}
/**
* Sets a site icon in options for testing.
* Sets a custom logo in options for testing.
*
* @since 4.5.0
*/
@ -415,7 +415,7 @@ class Tests_General_Template extends WP_UnitTestCase {
}
/**
* Removes the site icon from options.
* Removes the custom logo from options.
*
* @since 4.5.0
*/